Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1907453003: Add device frame svgs to devtools gypi (Closed)

Created:
4 years, 8 months ago by mmccoy
Modified:
4 years, 8 months ago
Reviewers:
paulirish, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add device frame svgs to devtools gypi BUG=411892 Committed: https://crrev.com/9f895237395317a017a9fb0fe3c8d8eb31bb9a92 Cr-Commit-Position: refs/heads/master@{#388573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mmccoy
PTAL, additional gypi definitions for newly added device frame assets.
4 years, 8 months ago (2016-04-20 17:51:06 UTC) #2
dgozman
lgtm! Sorry, I've missed that in review.
4 years, 8 months ago (2016-04-20 17:55:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907453003/1
4 years, 8 months ago (2016-04-20 17:57:46 UTC) #5
mmccoy
On 2016/04/20 at 17:55:54, dgozman wrote: > lgtm! > > Sorry, I've missed that in ...
4 years, 8 months ago (2016-04-20 17:58:20 UTC) #6
dgozman
On 2016/04/20 17:58:20, mmccoy wrote: > On 2016/04/20 at 17:55:54, dgozman wrote: > > lgtm! ...
4 years, 8 months ago (2016-04-20 17:59:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 20:54:06 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:26:22 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9f895237395317a017a9fb0fe3c8d8eb31bb9a92
Cr-Commit-Position: refs/heads/master@{#388573}

Powered by Google App Engine
This is Rietveld 408576698