Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1907453002: Make RenderFrameImpl own its frame blame context (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make RenderFrameImpl own its frame blame context RenderFrameImpl creates the respective frame blame context, but was mistakenly not freeing it. BUG=546021 Committed: https://crrev.com/e3adedbefcf4ae29f695aafe97b1ca1a9ca8bd9f Cr-Commit-Position: refs/heads/master@{#388481}

Patch Set 1 #

Patch Set 2 : Build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Sami
PTAL.
4 years, 8 months ago (2016-04-20 12:08:16 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-20 12:46:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907453002/20001
4 years, 8 months ago (2016-04-20 13:09:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 13:12:56 UTC) #8
Sami
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1909403002/ by skyostil@chromium.org. ...
4 years, 8 months ago (2016-04-22 13:45:33 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:22:58 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3adedbefcf4ae29f695aafe97b1ca1a9ca8bd9f
Cr-Commit-Position: refs/heads/master@{#388481}

Powered by Google App Engine
This is Rietveld 408576698