third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-openwindow-crash.html - Issue 1907443007: Use promises in notifications tests and enable controlling the page.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-openwindow-crash.html

Issue 1907443007: Use promises in notifications tests and enable controlling the page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Address peter's comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-action-reflection.html ('k') | third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Notifications: Calling openWindow() in a Service Worker should not cr ash.</title>	4 <title>Notifications: Calling openWindow() in a Service Worker should not cr ash.</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="../serviceworker/resources/test-helpers.js"></script>	7 <script src="../serviceworker/resources/test-helpers.js"></script>

8 <script src="resources/test-helpers.js"></script>	8 <script src="resources/test-helpers.js"></script>

9 </head>	9 </head>

10 <body>	10 <body>

11 <script>	11 <script>

12 // Tests that calling openWindow() in a Service Worker in response to a	12 // Tests that calling openWindow() in a Service Worker in response to a

13 // notificationclick event does not cause the browser to crash.	13 // notificationclick event does not cause the browser to crash.

14	14

15 async_test(function(test) {	15 async_test(function(test) {

16 var scope = 'resources/scope/' + location.pathname,	16 var scope = 'resources/scope/' + location.pathname;

17 script = 'resources/instrumentation-service-worker.js',	17 var script = 'instrumentation-service-worker.js';

18 workerInfo = null;	18 var port;

19	19

20 testRunner.setPermission('notifications', 'granted', location.origin, location.origin);	20 testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

21 getActiveServiceWorkerWithMessagePort(test, script, scope).then(functi on(info) {	21 getActiveServiceWorkerWithMessagePort(test, script, scope).then(functi on(info) {

22 workerInfo = info;	22 port = info.port;

23	23

24 // (1) Display a persistent notification with an OPENWINDOW trigge r.	24 // (1) Display a persistent notification with an OPENWINDOW trigge r.

25 return workerInfo.registration.showNotification(scope, {	25 return info.registration.showNotification(scope, {

26 body: 'ACTION:OPENWINDOW'	26 body: 'ACTION:OPENWINDOW'

27 });	27 });

28 }).then(function() {	28 }).then(function() {

29 // (2) Simulate a click on the notification, invokes the Service W orker event.	29 // (2) Simulate a click on the notification, invokes the Service W orker event.

30 testRunner.simulateWebNotificationClick(scope, -1 /* action_index */);	30 return simulateNotificationClick(scope, -1 /* action_index */, por t);

	31 }).then(function(data) {

	32 // (3) Confirm that the service worker successfully handled the no tificationclick

	33 // event for the correct notification.

	34 assert_equals(data.notification.title, scope);

31	35

32 workerInfo.port.addEventListener('message', function(event) {	36 test.done();

33 if (typeof event.data != 'object' \|\| !event.data.command) {

34 assert_unreached('Invalid message from the Service Worker. ');

35 return;

36 }

37

38 // (3) Listen for confirmation by the Service Worker that the notificationclick

39 // event has been executed successfully.

40 assert_equals(event.data.command, 'click');

41 assert_equals(event.data.notification.title, scope);

42

43 test.done();

44 });

45 }).catch(unreached_rejection(test));	37 }).catch(unreached_rejection(test));

46	38

47 }, 'Opening a window in a Service Worker should not trigger a DCHECK.');	39 }, 'Opening a window in a Service Worker should not trigger a DCHECK.');

48 </script>	40 </script>

49 </body>	41 </body>

50 </html>	42 </html>

OLD	NEW