Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2518)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1907443006: PlzNavigate: store POST data in the FrameNavigationEntry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index d45cdaae73337a466a57500d384aa5f935f24aee..a425a2ae13807c0b5f02de3afdb3dbfda952d191 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -150,6 +150,7 @@
#include "net/base/net_errors.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
#include "net/http/http_util.h"
+#include "storage/common/data_element.h"
#include "third_party/WebKit/public/platform/URLConversion.h"
#include "third_party/WebKit/public/platform/WebCachePolicy.h"
#include "third_party/WebKit/public/platform/WebData.h"
@@ -537,6 +538,47 @@ WebURLRequest CreateURLRequestForNavigation(
return request;
}
+// Converts the HTTP body data stored in ResourceRequestBody format to a
+// WebHTTPBody, which is then added to the WebURLRequest.
+// PlzNavigate: used to add the POST data sent by the renderer at commit time
+// to the WebURLRequest used to commit the navigation. This ensures that the
+// POST data will be in the PageState sent to the browser on commit.
+void AddHTTPBodyToRequest(WebURLRequest* request,
+ scoped_refptr<ResourceRequestBody> body) {
+ WebHTTPBody http_body;
+ http_body.initialize();
+ http_body.setIdentifier(body->identifier());
+ for (const ResourceRequestBody::Element& element : *(body->elements())) {
+ long long length = -1;
+ switch (element.type()) {
+ case storage::DataElement::TYPE_BYTES:
+ http_body.appendData(WebData(element.bytes(), element.length()));
+ break;
+ case storage::DataElement::TYPE_FILE:
+ if (element.length() != std::numeric_limits<uint64_t>::max())
+ length = element.length();
+ http_body.appendFileRange(
+ element.path().AsUTF16Unsafe(), element.offset(), length,
+ element.expected_modification_time().ToDoubleT());
+ break;
+ case storage::DataElement::TYPE_FILE_FILESYSTEM:
+ http_body.appendFileSystemURLRange(
+ element.filesystem_url(), element.offset(), element.length(),
+ element.expected_modification_time().ToDoubleT());
+ break;
+ case storage::DataElement::TYPE_BLOB:
+ http_body.appendBlob(WebString::fromUTF8(element.blob_uuid()));
+ break;
+ default:
+ // TYPE_BYTES_DESCRIPTION and TYPE_DISK_CACHE_ENTRY should not be
+ // encountered.
+ NOTREACHED();
+ break;
+ }
+ }
+ request->setHTTPBody(http_body);
+}
+
// Sanitizes the navigation_start timestamp for browser-initiated navigations,
// where the browser possibly has a better notion of start time than the
// renderer. In the case of cross-process navigations, this carries over the
@@ -1501,7 +1543,7 @@ void RenderFrameImpl::OnNavigate(
TRACE_EVENT2("navigation", "RenderFrameImpl::OnNavigate", "id", routing_id_,
"url", common_params.url.possibly_invalid_spec());
NavigateInternal(common_params, start_params, request_params,
- std::unique_ptr<StreamOverrideParameters>());
+ std::unique_ptr<StreamOverrideParameters>(), nullptr);
}
void RenderFrameImpl::BindServiceRegistry(
@@ -4638,7 +4680,8 @@ void RenderFrameImpl::OnCommitNavigation(
const ResourceResponseHead& response,
const GURL& stream_url,
const CommonNavigationParams& common_params,
- const RequestNavigationParams& request_params) {
+ const RequestNavigationParams& request_params,
+ scoped_refptr<ResourceRequestBody> post_data) {
CHECK(IsBrowserSideNavigationEnabled());
// This will override the url requested by the WebURLLoader, as well as
// provide it with the response to the request.
@@ -4648,7 +4691,7 @@ void RenderFrameImpl::OnCommitNavigation(
stream_override->response = response;
NavigateInternal(common_params, StartNavigationParams(), request_params,
- std::move(stream_override));
+ std::move(stream_override), post_data);
}
// PlzNavigate
@@ -5244,7 +5287,8 @@ void RenderFrameImpl::NavigateInternal(
const CommonNavigationParams& common_params,
const StartNavigationParams& start_params,
const RequestNavigationParams& request_params,
- std::unique_ptr<StreamOverrideParameters> stream_params) {
+ std::unique_ptr<StreamOverrideParameters> stream_params,
+ scoped_refptr<ResourceRequestBody> post_data) {
bool browser_side_navigation = IsBrowserSideNavigationEnabled();
// Lower bound for browser initiated navigation start time.
@@ -5305,6 +5349,9 @@ void RenderFrameImpl::NavigateInternal(
CreateURLRequestForNavigation(common_params, std::move(stream_params),
frame_->isViewSourceModeEnabled());
+ if (IsBrowserSideNavigationEnabled() && post_data)
+ AddHTTPBodyToRequest(&request, post_data);
+
// Used to determine whether this frame is actually loading a request as part
// of a history navigation.
bool has_history_navigation_in_frame = false;

Powered by Google App Engine
This is Rietveld 408576698