PlzNavigate: store POST data in the FrameNavigationEntry

content/browser/frame_host/navigation_entry_impl.cc

Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index 092281a6e51573406cd3598cad582d68b78097c3..81931e4b00a3c1788aa5f836f0e0888cd86bf4dd 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -19,6 +19,7 @@
 #include "content/common/navigation_params.h"
 #include "content/common/page_state_serialization.h"
 #include "content/common/site_isolation_policy.h"
+#include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/url_constants.h"
 #include "ui/gfx/text_elider.h"
@@ -569,6 +570,7 @@ std::unique_ptr<NavigationEntryImpl> NavigationEntryImpl::CloneAndReplace(
 }
 
 CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
+    const FrameNavigationEntry& frame_entry,
     const GURL& dest_url,
     const Referrer& dest_referrer,
     FrameMsg_Navigate_Type::Value navigation_type,
@@ -583,11 +585,20 @@ CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
   ui_timestamp = intent_received_timestamp();
 #endif
 
+  std::string method;
+
+  // TODO(clamy): Consult the FrameNavigationEntry in all modes that use
+  // subframe navigation entries.
+  if (IsBrowserSideNavigationEnabled())
+    method = frame_entry.method();

[Łukasz Anforowicz, 2016/05/12 02:53:59]

Just trying to understand: what is preventing consulting frame_entry.method() in
all the cases?  Is it just hardcoded method in 2 places in
NavigatorImpl::RequestTransferURL?  Or are there more places that don't
correctly populate frame_entry.method()?

[clamy, 2016/05/12 08:53:13]

The issue is that the current architecture expects the method to be set to POST
only for main frames, not subframes. So it's probably not populated properly if
you're not using subframe navigation entries.

[Łukasz Anforowicz, 2016/05/12 19:44:12]

Acknowledged.

+  else
+    method = GetHasPostData() ? "POST" : "GET";
+
   return CommonNavigationParams(
       dest_url, dest_referrer, GetTransitionType(), navigation_type,
       !IsViewSourceMode(), should_replace_entry(), ui_timestamp, report_type,
       GetBaseURLForDataURL(), GetHistoryURLForDataURL(), lofi_state,
-      navigation_start, GetHasPostData() ? "POST" : "GET");
+      navigation_start, method);
 }
 
 StartNavigationParams NavigationEntryImpl::ConstructStartNavigationParams()