Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 1907443006: PlzNavigate: store POST data in the FrameNavigationEntry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Not sending POST data when cross-site redirect Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index eccc0640c1fd30864f28044fb1d0c2b6e0cd1908..216fdff7b474615ddc7a694dae446e8699605004 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -19,6 +19,7 @@
#include "content/common/navigation_params.h"
#include "content/common/page_state_serialization.h"
#include "content/common/site_isolation_policy.h"
+#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/common/content_constants.h"
#include "content/public/common/url_constants.h"
#include "ui/gfx/text_elider.h"
@@ -573,6 +574,7 @@ std::unique_ptr<NavigationEntryImpl> NavigationEntryImpl::CloneAndReplace(
}
CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
+ const FrameNavigationEntry& frame_entry,
const GURL& dest_url,
const Referrer& dest_referrer,
FrameMsg_Navigate_Type::Value navigation_type,
@@ -587,11 +589,18 @@ CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
ui_timestamp = intent_received_timestamp();
#endif
+ std::string method;
+
+ if (IsBrowserSideNavigationEnabled())
Charlie Reis 2016/05/11 00:00:23 At some point, I think we'll need this in all UseS
clamy 2016/05/11 08:54:41 Added a TODO. I prefer this CL to stay focused on
+ method = frame_entry.method();
+ else
+ method = GetHasPostData() ? "POST" : "GET";
+
return CommonNavigationParams(
dest_url, dest_referrer, GetTransitionType(), navigation_type,
!IsViewSourceMode(), should_replace_entry(), ui_timestamp, report_type,
GetBaseURLForDataURL(), GetHistoryURLForDataURL(), lofi_state,
- navigation_start, GetHasPostData() ? "POST" : "GET");
+ navigation_start, method);
}
StartNavigationParams NavigationEntryImpl::ConstructStartNavigationParams()

Powered by Google App Engine
This is Rietveld 408576698