PlzNavigate: store POST data in the FrameNavigationEntry

content/browser/frame_host/frame_navigation_entry.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_FRAME_NAVIGATION_ENTRY_H_
 #define CONTENT_BROWSER_FRAME_HOST_FRAME_NAVIGATION_ENTRY_H_
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "content/browser/site_instance_impl.h"
+#include "content/common/resource_request_body.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/referrer.h"
 
 namespace content {
 
 // Represents a session history item for a particular frame.
 //
 // This class is refcounted and can be shared across multiple NavigationEntries.
 // For now, it is owned by a single NavigationEntry and only tracks the main
 // frame.
 //
 // If SiteIsolationPolicy::UseSubframeNavigationEntries is true, there will be a
 // tree of FrameNavigationEntries in each NavigationEntry, one per frame.
 // TODO(creis): Share these FrameNavigationEntries across NavigationEntries if
 // the frame hasn't changed.
 class CONTENT_EXPORT FrameNavigationEntry
     : public base::RefCounted<FrameNavigationEntry> {
  public:
   explicit FrameNavigationEntry(int frame_tree_node_id);
   FrameNavigationEntry(int frame_tree_node_id,
                        const std::string& frame_unique_name,
                        int64_t item_sequence_number,
                        int64_t document_sequence_number,
                        scoped_refptr<SiteInstanceImpl> site_instance,
                        const GURL& url,
                        const Referrer& referrer,
                        const std::string& method,
-                       int64_t post_id);
+                       int64_t post_id,
+                       scoped_refptr<ResourceRequestBody> post_data);
 
   // Creates a copy of this FrameNavigationEntry that can be modified
   // independently from the original.
   FrameNavigationEntry* Clone() const;
 
   // Updates all the members of this entry.
   void UpdateEntry(const std::string& frame_unique_name,
                    int64_t item_sequence_number,
                    int64_t document_sequence_number,
                    SiteInstanceImpl* site_instance,
                    const GURL& url,
                    const Referrer& referrer,
                    const PageState& page_state,
                    const std::string& method,
-                   int64_t post_id);
+                   int64_t post_id,
+                   scoped_refptr<ResourceRequestBody> post_data);
 
   // The ID of the FrameTreeNode this entry is for.  -1 for the main frame,
   // since we don't always know the FrameTreeNode ID when creating the overall
   // NavigationEntry.
   // TODO(creis): Consider removing |frame_tree_node_id| in favor of
   // |frame_unique_name|, if we can move unique name computation to the browser
   // process.
   int frame_tree_node_id() const { return frame_tree_node_id_; }
   void set_frame_tree_node_id(int frame_tree_node_id) {
     frame_tree_node_id_ = frame_tree_node_id;
@@ skipping 45 matching lines @@
 
   // The HTTP method used to navigate.
   const std::string& method() const { return method_; }
   void set_method(const std::string& method) { method_ = method; }
 
   // The id of the post corresponding to this navigation or -1 if the
   // navigation was not a POST.
   int64_t post_id() const { return post_id_; }
   void set_post_id(int64_t post_id) { post_id_ = post_id; }
 
+  // The data sent during a POST navigation. Returns nullptr if the navigation
+  // is not a POST.
+  ResourceRequestBody* post_data() const { return post_data_.get(); }
+  void set_post_data(scoped_refptr<ResourceRequestBody> post_data) {
+    DCHECK(!post_data || method_ == "POST");
+    post_data_ = post_data;
+  }
+
  private:
   friend class base::RefCounted<FrameNavigationEntry>;
   virtual ~FrameNavigationEntry();
 
   // WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
   // Add all new fields to |UpdateEntry|.
   // TODO(creis): These fields have implications for session restore.  This is
   // currently managed by NavigationEntry, but the logic will move here.
   // WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
 
   // See the accessors above for descriptions.
   int frame_tree_node_id_;
   std::string frame_unique_name_;
   int64_t item_sequence_number_;
   int64_t document_sequence_number_;
   scoped_refptr<SiteInstanceImpl> site_instance_;
   GURL url_;
   Referrer referrer_;
   // TODO(creis): Change this to FrameState.
   PageState page_state_;
   std::string method_;
   int64_t post_id_;
+  scoped_refptr<ResourceRequestBody> post_data_;

[Charlie Reis, 2016/04/27 23:00:55]

This wasn't stored on NavigationEntry before, was it?  How did it used to be
handled?

If it used to be in PageState, then I'm concerned that adding a second copy here
will be expensive.  (POST data can be large, right?)

Can we just get the data out of the FNE's PageState instead?

[clamy, 2016/04/29 16:07:16]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(FrameNavigationEntry);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_FRAME_NAVIGATION_ENTRY_H_