PlzNavigate: store POST data in the FrameNavigationEntry

content/browser/frame_host/render_frame_host_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_manager.h"
 
 #include <stdint.h>
 
 #include <utility>
 
@@ skipping 440 matching lines @@
               frame_entry->referrer(), *frame_entry, entry, navigate_type,
               LOFI_UNSPECIFIED, false, base::TimeTicks::Now(), controller);
 
       // Simulates request creation that triggers the 1st internal call to
       // GetFrameHostForNavigation.
       manager->DidCreateNavigationRequest(navigation_request.get());
 
       // And also simulates the 2nd and final call to GetFrameHostForNavigation
       // that determines the final frame that will commit the navigation.
       TestRenderFrameHost* frame_host = static_cast<TestRenderFrameHost*>(
-          manager->GetFrameHostForNavigation(*navigation_request));
+          manager->GetFrameHostForNavigation(navigation_request.get(), true));

[Charlie Reis, 2016/05/11 23:58:53]

Stale param, here and below.

[clamy, 2016/05/12 08:53:13]

Done.

       CHECK(frame_host);
       frame_host->set_pending_commit(true);
       return frame_host;
     }
 
     return manager->Navigate(frame_entry->url(), *frame_entry, entry);
   }
 
   // Returns the pending RenderFrameHost.
   // PlzNavigate: returns the speculative RenderFrameHost.
@@ skipping 2402 matching lines @@
   ASSERT_TRUE(host);
   EXPECT_NE(host, initial_host);
   EXPECT_TRUE(host->IsRenderFrameLive());
   WebUIImpl* web_ui = host->web_ui();
   EXPECT_TRUE(web_ui);
   EXPECT_FALSE(host->pending_web_ui());
   EXPECT_FALSE(manager->GetNavigatingWebUI());
   EXPECT_FALSE(GetPendingFrameHost(manager));
 
   // Prepare to commit, update the navigating RenderFrameHost.
-  EXPECT_EQ(host, manager->GetFrameHostForNavigation(*navigation_request));
+  EXPECT_EQ(host,
+            manager->GetFrameHostForNavigation(navigation_request.get(), true));
 
   // There should be a pending WebUI set to reuse the current one.
   EXPECT_EQ(web_ui, host->web_ui());
   EXPECT_EQ(web_ui, host->pending_web_ui());
   EXPECT_EQ(web_ui, manager->GetNavigatingWebUI());
 
   // No pending RenderFrameHost as the current one should be reused.
   EXPECT_FALSE(GetPendingFrameHost(manager));
 
   // The RenderFrameHost committed.
@@ skipping 35 matching lines @@
   manager->DidCreateNavigationRequest(navigation_request.get());
 
   // The current WebUI should still be in place and the pending WebUI should be
   // set to reuse it.
   EXPECT_EQ(web_ui, manager->GetNavigatingWebUI());
   EXPECT_EQ(web_ui, host->web_ui());
   EXPECT_EQ(web_ui, host->pending_web_ui());
   EXPECT_FALSE(GetPendingFrameHost(manager));
 
   // Prepare to commit, update the navigating RenderFrameHost.
-  EXPECT_EQ(host, manager->GetFrameHostForNavigation(*navigation_request));
+  EXPECT_EQ(host,
+            manager->GetFrameHostForNavigation(navigation_request.get(), true));
 
   EXPECT_EQ(web_ui, manager->GetNavigatingWebUI());
   EXPECT_EQ(web_ui, host->web_ui());
   EXPECT_EQ(web_ui, host->pending_web_ui());
   EXPECT_FALSE(GetPendingFrameHost(manager));
 
   // The RenderFrameHost committed.
   manager->DidNavigateFrame(host, true);
   EXPECT_EQ(web_ui, host->web_ui());
   EXPECT_FALSE(manager->GetNavigatingWebUI());
@@ skipping 43 matching lines @@
   RenderFrameHostImpl* speculative_host = GetPendingFrameHost(manager);
   EXPECT_TRUE(speculative_host);
   WebUIImpl* next_web_ui = manager->GetNavigatingWebUI();
   EXPECT_TRUE(next_web_ui);
   EXPECT_EQ(next_web_ui, speculative_host->web_ui());
   EXPECT_NE(next_web_ui, manager->current_frame_host()->web_ui());
   EXPECT_FALSE(speculative_host->pending_web_ui());
 
   // Prepare to commit, update the navigating RenderFrameHost.
   EXPECT_EQ(speculative_host,
-            manager->GetFrameHostForNavigation(*navigation_request));
+            manager->GetFrameHostForNavigation(navigation_request.get(), true));
 
   EXPECT_TRUE(manager->current_frame_host()->web_ui());
   EXPECT_FALSE(manager->current_frame_host()->pending_web_ui());
   EXPECT_EQ(speculative_host, GetPendingFrameHost(manager));
   EXPECT_NE(next_web_ui, manager->current_frame_host()->web_ui());
   EXPECT_EQ(next_web_ui, speculative_host->web_ui());
   EXPECT_EQ(next_web_ui, manager->GetNavigatingWebUI());
   EXPECT_FALSE(speculative_host->pending_web_ui());
 
   // The RenderFrameHost committed.
@@ skipping 86 matching lines @@
   commit_params.should_enforce_strict_mixed_content_checking = false;
   child_host->SendNavigateWithParams(&commit_params);
   EXPECT_NO_FATAL_FAILURE(CheckMixedContentIPC(
       main_test_rfh(), false, proxy_to_parent->GetRoutingID()));
   EXPECT_FALSE(root->child_at(0)
                    ->current_replication_state()
                    .should_enforce_strict_mixed_content_checking);
 }
 
 }  // namespace content