third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h - Issue 1907443003: Translate flow thread coords to the nearest enclosing coord space when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 1907443003: Translate flow thread coords to the nearest enclosing coord space when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a unit test too. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp ('K') | « third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp ('k') | third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

index e1ca9abfb033b437823dacbe081332bfcfe7ec5b..92205c64e21efb24dc518712d8374f76e5a3982a 100644

--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

@@ -62,7 +62,7 @@ public:

void resetColumnHeight();

bool recalculateColumnHeight();

- LayoutSize flowThreadTranslationAtOffset(LayoutUnit offsetInFlowThread) const;

+ LayoutSize flowThreadTranslationAtOffset(LayoutUnit, CoordinateSpaceConversion) const;

LayoutUnit columnLogicalTopForOffset(LayoutUnit offsetInFlowThread) const;

LayoutPoint visualPointToFlowThreadPoint(const LayoutPoint& visualPoint) const;

LayoutRect fragmentsBoundingBox(const LayoutRect& boundingBoxInFlowThread) const;