third_party/WebKit/Source/core/layout/LayoutObject.h - Issue 1907443003: Translate flow thread coords to the nearest enclosing coord space when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 1907443003: Translate flow thread coords to the nearest enclosing coord space when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a unit test too. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp ('k') | third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h

index 69bd9737d3e2b5fd2c46642cac48506225f2dc2f..f62bfd04ce32eff3afad0fd941e8da90fe2032d6 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h

@@ -1161,7 +1161,7 @@ public:

virtual bool mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ancestor, LayoutRect&, VisualRectFlags = DefaultVisualRectFlags) const;

// Return the offset to the column in which the specified point (in flow-thread coordinates)

- // lives. This is used to convert a flow-thread point to a visual point.

+ // lives. This is used to convert a flow-thread point to a point in the containing coordinate space.

virtual LayoutSize columnOffset(const LayoutPoint&) const { return LayoutSize(); }

virtual unsigned length() const { return 1; }