[Android,MediaFling] Fix the encoding issue with already encoded URLs for abc13.com/live

[Android,MediaFling] Fix the encoding issue with already encoded URLs for abc13.com/live

Also some cleanup of error handling, url type conversions and media type detection,
extend the UMA to cover more failure cases.

BUG=605544
TEST=unit tests + avayvod.github.io/mediaflingtest.html

Committed: https://crrev.com/e358d10bb42b0699c2db6276b57d6b9963be4b24
Cr-Commit-Position: refs/heads/master@{#389735}

[whywhat, 2016-04-22 19:08:59]

Fixed existing unit tests

[whywhat, 2016-04-22 19:11:03]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[whywhat, 2016-04-22 19:11:15]

avayvod@chromium.org changed reviewers:
+ aberent@chromium.org

[whywhat, 2016-04-22 19:11:15]

PTaL

[commit-bot: I haz the power, 2016-04-22 19:11:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907413002/20001

[commit-bot: I haz the power, 2016-04-22 20:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 20:36:15]

Dry run: This issue passed the CQ dry run.

[whywhat, 2016-04-25 11:54:55]

Updated test cases

[whywhat, 2016-04-25 11:56:14]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 11:56:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907413002/40001

[whywhat, 2016-04-25 11:56:38]

PTAL

[commit-bot: I haz the power, 2016-04-25 13:02:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 13:02:56]

Dry run: This issue passed the CQ dry run.

[aberent, 2016-04-25 17:06:59]

lgtm

[whywhat, 2016-04-25 18:49:25]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2016-04-25 18:49:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907413002/40001

[commit-bot: I haz the power, 2016-04-25 19:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 19:03:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[whywhat, 2016-04-25 20:14:53]

avayvod@chromium.org changed reviewers:
+ isherman@chromium.org

[whywhat, 2016-04-25 20:14:53]

+Ilya for the histograms.xml

[Ilya Sherman, 2016-04-25 20:15:57]

histograms.xml lgtm

[Ilya Sherman, 2016-04-25 20:16:11]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2016-04-25 20:16:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907413002/40001

[commit-bot: I haz the power, 2016-04-25 20:21:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 20:22:04]

Failed to commit the patch.

[commit-bot: I haz the power, 2016-04-25 20:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[whywhat, 2016-04-25 20:26:38]

avayvod@chromium.org changed reviewers:
+ mmenke@chromium.org

[whywhat, 2016-04-25 20:26:38]

+mmenke to check if escaping the url is done correctly

[whywhat, 2016-04-26 09:43:36]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2016-04-26 09:43:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907413002/40001

[commit-bot: I haz the power, 2016-04-26 09:48:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-26 09:50:32]

Description was changed from

==========
[Android,MediaFling] Fix the encoding issue with already encoded URLs for
abc13.com/live

Also some cleanup of error handling, url type conversions and media type
detection,
extend the UMA to cover more failure cases.

BUG=605544
TEST=unit tests + avayvod.github.io/mediaflingtest.html
==========

to

==========
[Android,MediaFling] Fix the encoding issue with already encoded URLs for
abc13.com/live

Also some cleanup of error handling, url type conversions and media type
detection,
extend the UMA to cover more failure cases.

BUG=605544
TEST=unit tests + avayvod.github.io/mediaflingtest.html

Committed: https://crrev.com/e358d10bb42b0699c2db6276b57d6b9963be4b24
Cr-Commit-Position: refs/heads/master@{#389735}
==========

[commit-bot: I haz the power, 2016-04-26 09:50:34]

Patchset 3 (id:??) landed as
https://crrev.com/e358d10bb42b0699c2db6276b57d6b9963be4b24
Cr-Commit-Position: refs/heads/master@{#389735}

[mmenke, 2016-04-26 15:02:51]

On 2016/04/26 09:50:34, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/e358d10bb42b0699c2db6276b57d6b9963be4b24
> Cr-Commit-Position: refs/heads/master@{#389735}

Sorry I didn't get to this yesterday - punted almost all my reviews yesterday
due to review overload.  This looks correct to me, though I'm not familiar with 
EscapeExternalHandlerValue.

[whywhat, 2016-04-26 15:11:04]

On 2016/04/26 at 15:02:51, mmenke wrote:
> On 2016/04/26 09:50:34, commit-bot: I haz the power wrote:
> > Patchset 3 (id:??) landed as
> > https://crrev.com/e358d10bb42b0699c2db6276b57d6b9963be4b24
> > Cr-Commit-Position: refs/heads/master@{#389735}
> 
> Sorry I didn't get to this yesterday - punted almost all my reviews yesterday
due to review overload.  This looks correct to me, though I'm not familiar with 
EscapeExternalHandlerValue.

No worries, thanks for the follow up!