Implement arflags in the GN build.

Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1909163002 with no changes (now that a GN binary push to fix the bug has gone in) which was a reland of http://crrev.com/1896163003 with fix.

Committed: https://crrev.com/897cde76d084732227ea88af76163e33eda18778
Cr-Commit-Position: refs/heads/master@{#390424}

[brettw, 2016-04-22 18:18:42]

Description was changed from

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1896163003 with fix.
==========

to

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1909163002 with fix which was a reland of
http://crrev.com/1896163003 with fix.
==========

[brettw, 2016-04-22 18:20:26]

Description was changed from

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1909163002 with fix which was a reland of
http://crrev.com/1896163003 with fix.
==========

to

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

This keeps the --plugin call for Posix on the toolchain rather than in the
arflags due to possibly causing mysterious errors on previous landing.
Theoretically this should be moved to arflags in a shared config as in the
previous patch.

BUG=598599
Reland of http://crrev.com/1909163002 with fix which was a reland of
http://crrev.com/1896163003 with fix.
==========

[brettw, 2016-04-22 18:20:26]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brettw, 2016-04-22 18:20:32]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 18:21:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907403002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907403002/20001

[commit-bot: I haz the power, 2016-04-22 19:16:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 19:16:08]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-04-22 22:32:32]

We need to understand why LNK4221 isn't being suppressed before landing. See:
https://bugs.chromium.org/p/chromium/issues/detail?id=598599#c13

I noticed a significant number of these warnings after the previous time this
landed.

[brettw, 2016-04-25 19:18:28]

Description was changed from

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

This keeps the --plugin call for Posix on the toolchain rather than in the
arflags due to possibly causing mysterious errors on previous landing.
Theoretically this should be moved to arflags in a shared config as in the
previous patch.

BUG=598599
Reland of http://crrev.com/1909163002 with fix which was a reland of
http://crrev.com/1896163003 with fix.
==========

to

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1909163002 with no changes (now that a GN binary push
to fix the bug has gone in) which was a reland of http://crrev.com/1896163003
with fix.
==========

[brettw, 2016-04-25 19:18:59]

I tracked down the problem and sent a GN patch to you for review. This patch is
now the same as the previous landing.

[brucedawson, 2016-04-25 21:30:55]

On 2016/04/25 19:18:59, brettw wrote:
> I tracked down the problem and sent a GN patch to you for review. This patch
is
> now the same as the previous landing.

Should this patch work now on local testing? Or do I need to wait for a gn roll?

[brettw, 2016-04-25 22:41:50]

You'll need a new GN first. You can compile your own in about 60 seconds though:
  ninja -C out/foo gn
  out/foo/gn gen out/bar

[brucedawson, 2016-04-26 00:21:18]

Tested - it works with the new gn. So this lgtm and is okay to land as long as a
new gn binary is rolled.

[brettw, 2016-04-28 16:42:59]

merge

[brettw, 2016-04-28 16:43:00]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-04-28 16:43:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/1907403002/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2016-04-28 16:43:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907403002/60001

[commit-bot: I haz the power, 2016-04-28 17:29:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 17:29:16]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-04-28 17:44:08]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-04-28 17:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907403002/60001

[commit-bot: I haz the power, 2016-04-28 18:21:26]

Description was changed from

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1909163002 with no changes (now that a GN binary push
to fix the bug has gone in) which was a reland of http://crrev.com/1896163003
with fix.
==========

to

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1909163002 with no changes (now that a GN binary push
to fix the bug has gone in) which was a reland of http://crrev.com/1896163003
with fix.
==========

[commit-bot: I haz the power, 2016-04-28 18:21:27]

Committed patchset #4 (id:60001)

[bpastene, 2016-04-29 00:33:43]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1930293002/ by bpastene@chromium.org.

The reason for reverting is: As with the previous attempts to land this cl,
android and GPU builders are failing compile with OOM errors:
https://bugs.chromium.org/p/chromium/issues/detail?id=607673.

[commit-bot: I haz the power, 2016-04-30 17:19:39]

Patchset 4 (id:??) landed as
https://crrev.com/897cde76d084732227ea88af76163e33eda18778
Cr-Commit-Position: refs/heads/master@{#390424}

[commit-bot: I haz the power, 2016-04-30 17:56:33]

Description was changed from

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1909163002 with no changes (now that a GN binary push
to fix the bug has gone in) which was a reland of http://crrev.com/1896163003
with fix.
==========

to

==========
Implement arflags in the GN build.

This flag was recently added in GN. This patch hooks it up to the toolchains
and moves some flags to use it that previously had to be hardcoded on the
tool command itself.

Remove concurrent_links variable from gcc_toolchain which was unused.

BUG=598599
Reland of http://crrev.com/1909163002 with no changes (now that a GN binary push
to fix the bug has gone in) which was a reland of http://crrev.com/1896163003
with fix.

Committed: https://crrev.com/897cde76d084732227ea88af76163e33eda18778
Cr-Commit-Position: refs/heads/master@{#390424}
==========