Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1907393002: Fix hash field access for 64-bit big-endian architectures. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, JaideepBajwa, JoranSiu
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix hash field access for 64-bit big-endian architectures. Need to use the kHashFieldSlot rather than kHashFieldOffset for pointer-sized memory accesses. (Fix for "[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan.") R=bmeurer@chromium.org, epertoso@chromium.org BUG= Committed: https://crrev.com/b0530dc96bbe5068b67c731074daee79610a37a7 Cr-Commit-Position: refs/heads/master@{#35741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/code-stub-assembler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
MTBrandyberry
PTAL
4 years, 8 months ago (2016-04-22 17:59:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907393002/1
4 years, 8 months ago (2016-04-22 17:59:17 UTC) #4
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-22 18:06:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 18:27:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907393002/1
4 years, 8 months ago (2016-04-22 18:38:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 18:40:19 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0530dc96bbe5068b67c731074daee79610a37a7
Cr-Commit-Position: refs/heads/master@{#35741}

Powered by Google App Engine
This is Rietveld 408576698