src/compiler/mips64/instruction-selector-mips64.cc - Issue 1907363002: MIPS64: Fix [turbofan] Length and index2 are unsigned in CheckedLoad/CheckedStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/mips64/instruction-selector-mips64.cc

Issue 1907363002: MIPS64: Fix [turbofan] Length and index2 are unsigned in CheckedLoad/CheckedStore. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebased. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/mips64/instruction-selector-mips64.cc

diff --git a/src/compiler/mips64/instruction-selector-mips64.cc b/src/compiler/mips64/instruction-selector-mips64.cc

index f1cee6060091d20747c52599bd892ec4662ef3b7..360dc69d62210549681afdb65a880b9859b267a5 100644

--- a/src/compiler/mips64/instruction-selector-mips64.cc

+++ b/src/compiler/mips64/instruction-selector-mips64.cc

@@ -158,7 +158,7 @@ void InstructionSelector::VisitLoad(Node* node) {

opcode = load_rep.IsUnsigned() ? kMips64Lhu : kMips64Lh;

break;

case MachineRepresentation::kWord32:

- opcode = kMips64Lw;

+ opcode = load_rep.IsUnsigned() ? kMips64Lwu : kMips64Lw;

break;

case MachineRepresentation::kTagged: // Fall through.

case MachineRepresentation::kWord64:

« no previous file with comments | « src/compiler/mips64/instruction-codes-mips64.h ('k') | no next file » | no next file with comments »