Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h

Issue 1907333002: Order bounds update correctly for LayoutSVGShape and LayoutSVGImage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Shuffle clientLayoutChanged instead. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2006 Apple Computer, Inc 5 * Copyright (C) 2006 Apple Computer, Inc
6 * Copyright (C) 2009 Google, Inc. 6 * Copyright (C) 2009 Google, Inc.
7 * Copyright (C) 2011 Renata Hodovan <reni@webkit.org> 7 * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>
8 * Copyright (C) 2011 University of Szeged 8 * Copyright (C) 2011 University of Szeged
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVGShape || LayoutSVGModelObject::isOfType(type); } 117 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVGShape || LayoutSVGModelObject::isOfType(type); }
118 void layout() final; 118 void layout() final;
119 void paint(const PaintInfo&, const LayoutPoint&) const final; 119 void paint(const PaintInfo&, const LayoutPoint&) const final;
120 void addOutlineRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffse t, IncludeBlockVisualOverflowOrNot) const final; 120 void addOutlineRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffse t, IncludeBlockVisualOverflowOrNot) const final;
121 121
122 bool nodeAtFloatPoint(HitTestResult&, const FloatPoint& pointInParent, HitTe stAction) final; 122 bool nodeAtFloatPoint(HitTestResult&, const FloatPoint& pointInParent, HitTe stAction) final;
123 123
124 FloatRect strokeBoundingBox() const final { return m_strokeBoundingBox; } 124 FloatRect strokeBoundingBox() const final { return m_strokeBoundingBox; }
125 FloatRect calculateObjectBoundingBox() const; 125 FloatRect calculateObjectBoundingBox() const;
126 FloatRect calculateStrokeBoundingBox() const; 126 FloatRect calculateStrokeBoundingBox() const;
127 void updatePaintInvalidationBoundingBox();
128 void updateLocalTransform(); 127 void updateLocalTransform();
129 128
130 private: 129 private:
131 AffineTransform m_localTransform; 130 AffineTransform m_localTransform;
132 // TODO(fmalita): the Path is now cached in SVGPath; while this additional c ache is just a 131 // TODO(fmalita): the Path is now cached in SVGPath; while this additional c ache is just a
133 // shallow copy, it certainly has a complexity/state management cost (plus a llocation & storage 132 // shallow copy, it certainly has a complexity/state management cost (plus a llocation & storage
134 // overhead) - so we should look into removing it. 133 // overhead) - so we should look into removing it.
135 OwnPtr<Path> m_path; 134 OwnPtr<Path> m_path;
136 mutable OwnPtr<LayoutSVGShapeRareData> m_rareData; 135 mutable OwnPtr<LayoutSVGShapeRareData> m_rareData;
137 136
138 bool m_needsBoundariesUpdate : 1; 137 bool m_needsBoundariesUpdate : 1;
139 bool m_needsShapeUpdate : 1; 138 bool m_needsShapeUpdate : 1;
140 bool m_needsTransformUpdate : 1; 139 bool m_needsTransformUpdate : 1;
141 }; 140 };
142 141
143 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGShape, isSVGShape()); 142 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGShape, isSVGShape());
144 143
145 } // namespace blink 144 } // namespace blink
146 145
147 #endif 146 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698