Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp

Issue 1907333002: Order bounds update correctly for LayoutSVGShape and LayoutSVGImage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Shuffle clientLayoutChanged instead. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. All rights reserved. 5 * Copyright (C) 2009 Google, Inc. All rights reserved.
6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 SVGResourcesCache::clientLayoutChanged(this); 74 SVGResourcesCache::clientLayoutChanged(this);
75 75
76 if (m_needsBoundariesUpdate || updatedTransform) { 76 if (m_needsBoundariesUpdate || updatedTransform) {
77 updateCachedBoundaries(); 77 updateCachedBoundaries();
78 m_needsBoundariesUpdate = false; 78 m_needsBoundariesUpdate = false;
79 79
80 // If our bounds changed, notify the parents. 80 // If our bounds changed, notify the parents.
81 LayoutSVGModelObject::setNeedsBoundariesUpdate(); 81 LayoutSVGModelObject::setNeedsBoundariesUpdate();
82 } 82 }
83 83
84 ASSERT(!m_needsBoundariesUpdate);
84 clearNeedsLayout(); 85 clearNeedsLayout();
85 } 86 }
86 87
87 void LayoutSVGContainer::addChild(LayoutObject* child, LayoutObject* beforeChild ) 88 void LayoutSVGContainer::addChild(LayoutObject* child, LayoutObject* beforeChild )
88 { 89 {
89 LayoutSVGModelObject::addChild(child, beforeChild); 90 LayoutSVGModelObject::addChild(child, beforeChild);
90 SVGResourcesCache::clientWasAddedToTree(child, child->styleRef()); 91 SVGResourcesCache::clientWasAddedToTree(child, child->styleRef());
91 92
92 bool shouldIsolateDescendants = (child->isBlendingAllowed() && child->style( )->hasBlendMode()) || child->hasNonIsolatedBlendingDescendants(); 93 bool shouldIsolateDescendants = (child->isBlendingAllowed() && child->style( )->hasBlendMode()) || child->hasNonIsolatedBlendingDescendants();
93 if (shouldIsolateDescendants) 94 if (shouldIsolateDescendants)
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 updateHitTestResult(result, localLayoutPoint); 195 updateHitTestResult(result, localLayoutPoint);
195 if (result.addNodeToListBasedTestResult(element(), localLayoutPoint) == StopHitTesting) 196 if (result.addNodeToListBasedTestResult(element(), localLayoutPoint) == StopHitTesting)
196 return true; 197 return true;
197 } 198 }
198 } 199 }
199 // 16.4: "If there are no graphics elements whose relevant graphics content is under the pointer (i.e., there is no target element), the event is not dispat ched." 200 // 16.4: "If there are no graphics elements whose relevant graphics content is under the pointer (i.e., there is no target element), the event is not dispat ched."
200 return false; 201 return false;
201 } 202 }
202 203
203 } // namespace blink 204 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698