ash/drag_drop/drag_drop_controller.cc - Issue 1907323003: Drag and drop cleans up touch sequences from the source window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/drag_drop/drag_drop_controller.cc

Issue 1907323003: Drag and drop cleans up touch sequences from the source window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update GR state without actually dispatching press events. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/drag_drop/drag_drop_controller.cc

diff --git a/ash/drag_drop/drag_drop_controller.cc b/ash/drag_drop/drag_drop_controller.cc

index e2c6e6a43ebdf1cc673b58d665136144af635e89..4e04911f9ad0eb1f67a969882d1247393baeac01 100644

--- a/ash/drag_drop/drag_drop_controller.cc

+++ b/ash/drag_drop/drag_drop_controller.cc

@@ -173,8 +173,8 @@ int DragDropController::StartDragAndDrop(

// We need to transfer the current gesture sequence and the GR's touch event

// queue to the |drag_drop_tracker_|'s capture window so that when it takes

// capture, it still gets a valid gesture state.

- ui::GestureRecognizer::Get()->TransferEventsTo(source_window,

- tracker->capture_window());

+ ui::GestureRecognizer::Get()->BeginDragAndDrop(source_window,

+ tracker->capture_window());

// We also send a gesture end to the source window so it can clear state.

// TODO(varunjain): Remove this whole block when gesture sequence

// transferring is properly done in the GR (http://crbug.com/160558)

« no previous file with comments | « no previous file | ash/shelf/shelf_tooltip_manager_unittest.cc » ('j') | ui/aura/window_event_dispatcher.cc » ('J')