Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2857)

Unified Diff: ash/shelf/shelf_tooltip_manager_unittest.cc

Issue 1907323003: Drag and drop cleans up touch sequences from the source window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Mac. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/drag_drop/drag_drop_controller.cc ('k') | chrome/browser/ui/views/tabs/tab_drag_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_tooltip_manager_unittest.cc
diff --git a/ash/shelf/shelf_tooltip_manager_unittest.cc b/ash/shelf/shelf_tooltip_manager_unittest.cc
index 1e11c5bcf2c14a770ffb930acb18fd906edbce3b..72dcaced973866571a5e23b78ca9796f8c7817cc 100644
--- a/ash/shelf/shelf_tooltip_manager_unittest.cc
+++ b/ash/shelf/shelf_tooltip_manager_unittest.cc
@@ -185,6 +185,7 @@ TEST_F(ShelfTooltipManagerTest, HideForExternalEvents) {
generator.set_current_location(gfx::Point());
generator.PressTouch();
EXPECT_EQ(TooltipIsVisible(), !closes);
+ generator.ReleaseTouch();
// Should hide for touch events on the tooltip.
ShowImmediately();
@@ -192,6 +193,7 @@ TEST_F(ShelfTooltipManagerTest, HideForExternalEvents) {
generator.set_current_location(GetTooltipWindow()->bounds().CenterPoint());
generator.PressTouch();
EXPECT_EQ(TooltipIsVisible(), !closes);
+ generator.ReleaseTouch();
// Should hide for gestures outside the shelf.
ShowImmediately();
« no previous file with comments | « ash/drag_drop/drag_drop_controller.cc ('k') | chrome/browser/ui/views/tabs/tab_drag_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698