Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove yoda disable. fix throw parens Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 var debuggerModel = WebInspector.DebuggerModel.fromTarget(target); 553 var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);
554 if (!debuggerModel || !debuggerModel.isPaused()) { 554 if (!debuggerModel || !debuggerModel.isPaused()) {
555 this._popoverHelper.hidePopover(); 555 this._popoverHelper.hidePopover();
556 return; 556 return;
557 } 557 }
558 var lineNumber = anchorBox.highlight.lineNumber; 558 var lineNumber = anchorBox.highlight.lineNumber;
559 var startHighlight = anchorBox.highlight.startColumn; 559 var startHighlight = anchorBox.highlight.startColumn;
560 var endHighlight = anchorBox.highlight.endColumn; 560 var endHighlight = anchorBox.highlight.endColumn;
561 var line = this.textEditor.line(lineNumber); 561 var line = this.textEditor.line(lineNumber);
562 if (!anchorBox.forSelection) { 562 if (!anchorBox.forSelection) {
563 while (startHighlight > 1 && line.charAt(startHighlight - 1) === '.' ) { 563 while (startHighlight > 1 && line.charAt(startHighlight - 1) === "." ) {
564 var token = this.textEditor.tokenAtTextPosition(lineNumber, star tHighlight - 2); 564 var token = this.textEditor.tokenAtTextPosition(lineNumber, star tHighlight - 2);
565 if (!token || !token.type) { 565 if (!token || !token.type) {
566 this._popoverHelper.hidePopover(); 566 this._popoverHelper.hidePopover();
567 return; 567 return;
568 } 568 }
569 startHighlight = token.startColumn; 569 startHighlight = token.startColumn;
570 } 570 }
571 } 571 }
572 var evaluationText = line.substring(startHighlight, endHighlight + 1); 572 var evaluationText = line.substring(startHighlight, endHighlight + 1);
573 var selectedCallFrame = /** @type {!WebInspector.DebuggerModel.CallFrame }*/ (debuggerModel.selectedCallFrame()); 573 var selectedCallFrame = /** @type {!WebInspector.DebuggerModel.CallFrame }*/ (debuggerModel.selectedCallFrame());
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
742 * @param {?Array.<!WebInspector.RemoteObjectProperty>} properties 742 * @param {?Array.<!WebInspector.RemoteObjectProperty>} properties
743 * @param {?Array.<!WebInspector.RemoteObjectProperty>} internalProperties 743 * @param {?Array.<!WebInspector.RemoteObjectProperty>} internalProperties
744 */ 744 */
745 _prepareScopeVariables: function(callFrame, properties, internalProperties) 745 _prepareScopeVariables: function(callFrame, properties, internalProperties)
746 { 746 {
747 if (!properties || !properties.length || properties.length > 500) { 747 if (!properties || !properties.length || properties.length > 500) {
748 this._clearValueWidgets(); 748 this._clearValueWidgets();
749 return; 749 return;
750 } 750 }
751 751
752 var functionUILocation = WebInspector.debuggerWorkspaceBinding.rawLocati onToUILocation(/**@type {!WebInspector.DebuggerModel.Location} */ (callFrame.fun ctionLocation())); 752 var functionUILocation = WebInspector.debuggerWorkspaceBinding.rawLocati onToUILocation(/** @type {!WebInspector.DebuggerModel.Location} */ (callFrame.fu nctionLocation()));
753 var executionUILocation = WebInspector.debuggerWorkspaceBinding.rawLocat ionToUILocation(callFrame.location()); 753 var executionUILocation = WebInspector.debuggerWorkspaceBinding.rawLocat ionToUILocation(callFrame.location());
754 if (functionUILocation.uiSourceCode !== this.uiSourceCode() || execution UILocation.uiSourceCode !== this.uiSourceCode()) { 754 if (functionUILocation.uiSourceCode !== this.uiSourceCode() || execution UILocation.uiSourceCode !== this.uiSourceCode()) {
755 this._clearValueWidgets(); 755 this._clearValueWidgets();
756 return; 756 return;
757 } 757 }
758 758
759 var fromLine = functionUILocation.lineNumber; 759 var fromLine = functionUILocation.lineNumber;
760 var fromColumn = functionUILocation.columnNumber; 760 var fromColumn = functionUILocation.columnNumber;
761 var toLine = executionUILocation.lineNumber; 761 var toLine = executionUILocation.lineNumber;
762 762
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyChanged, this._workingCopyChanged, this); 1129 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyChanged, this._workingCopyChanged, this);
1130 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyCommitted, this._workingCopyCommitted, this); 1130 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyCommitted, this._workingCopyCommitted, this);
1131 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .TitleChanged, this._showBlackboxInfobarIfNeeded, this); 1131 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .TitleChanged, this._showBlackboxInfobarIfNeeded, this);
1132 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this); 1132 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this);
1133 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this); 1133 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this);
1134 WebInspector.UISourceCodeFrame.prototype.dispose.call(this); 1134 WebInspector.UISourceCodeFrame.prototype.dispose.call(this);
1135 }, 1135 },
1136 1136
1137 __proto__: WebInspector.UISourceCodeFrame.prototype 1137 __proto__: WebInspector.UISourceCodeFrame.prototype
1138 } 1138 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698