Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove yoda disable. fix throw parens Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 var obj = consoleMessage.parameters ? consoleMessage.par ameters[0] : undefined; 169 var obj = consoleMessage.parameters ? consoleMessage.par ameters[0] : undefined;
170 var args = ["%O", obj]; 170 var args = ["%O", obj];
171 this._messageElement = this._format(args); 171 this._messageElement = this._format(args);
172 break; 172 break;
173 case WebInspector.ConsoleMessage.MessageType.Profile: 173 case WebInspector.ConsoleMessage.MessageType.Profile:
174 case WebInspector.ConsoleMessage.MessageType.ProfileEnd: 174 case WebInspector.ConsoleMessage.MessageType.ProfileEnd:
175 this._messageElement = this._format([consoleMessage.mess ageText]); 175 this._messageElement = this._format([consoleMessage.mess ageText]);
176 break; 176 break;
177 default: 177 default:
178 if (consoleMessage.parameters && consoleMessage.paramete rs.length === 1 && consoleMessage.parameters[0].type === "string") 178 if (consoleMessage.parameters && consoleMessage.paramete rs.length === 1 && consoleMessage.parameters[0].type === "string")
179 this._messageElement = this._tryFormatAsError(/**@t ype {string} */(consoleMessage.parameters[0].value)); 179 this._messageElement = this._tryFormatAsError(/** @ type {string} */(consoleMessage.parameters[0].value));
180 180
181 var args = consoleMessage.parameters || [consoleMessage. messageText]; 181 var args = consoleMessage.parameters || [consoleMessage. messageText];
182 this._messageElement = this._messageElement || this._for mat(args); 182 this._messageElement = this._messageElement || this._for mat(args);
183 } 183 }
184 } else if (consoleMessage.source === WebInspector.ConsoleMessage.Mes sageSource.Network) { 184 } else if (consoleMessage.source === WebInspector.ConsoleMessage.Mes sageSource.Network) {
185 if (consoleMessage.request) { 185 if (consoleMessage.request) {
186 this._messageElement = createElement("span"); 186 this._messageElement = createElement("span");
187 if (consoleMessage.level === WebInspector.ConsoleMessage.Mes sageLevel.Error || consoleMessage.level === WebInspector.ConsoleMessage.MessageL evel.RevokedError) { 187 if (consoleMessage.level === WebInspector.ConsoleMessage.Mes sageLevel.Error || consoleMessage.level === WebInspector.ConsoleMessage.MessageL evel.RevokedError) {
188 this._messageElement.createTextChildren(consoleMessage.r equest.requestMethod, " "); 188 this._messageElement.createTextChildren(consoleMessage.r equest.requestMethod, " ");
189 this._messageElement.appendChild(WebInspector.Linkifier. linkifyUsingRevealer(consoleMessage.request, consoleMessage.request.url, console Message.request.url)); 189 this._messageElement.appendChild(WebInspector.Linkifier. linkifyUsingRevealer(consoleMessage.request, consoleMessage.request.url, console Message.request.url));
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
629 if (lines.length > 1) { 629 if (lines.length > 1) {
630 var detailedLink = elem.createChild("a"); 630 var detailedLink = elem.createChild("a");
631 detailedLink.textContent = "(\u2026)"; 631 detailedLink.textContent = "(\u2026)";
632 function showDetailed(event) 632 function showDetailed(event)
633 { 633 {
634 span.removeChildren(); 634 span.removeChildren();
635 detailedLink.remove(); 635 detailedLink.remove();
636 span.appendChild(WebInspector.linkifyStringAsFragment(text)); 636 span.appendChild(WebInspector.linkifyStringAsFragment(text));
637 event.consume(true); 637 event.consume(true);
638 } 638 }
639 detailedLink._showDetailedForTest = showDetailed.bind(null, new Mous eEvent('click')); 639 detailedLink._showDetailedForTest = showDetailed.bind(null, new Mous eEvent("click"));
640 detailedLink.addEventListener("click", showDetailed, false); 640 detailedLink.addEventListener("click", showDetailed, false);
641 } 641 }
642 }, 642 },
643 643
644 /** 644 /**
645 * @param {!WebInspector.RemoteObject} array 645 * @param {!WebInspector.RemoteObject} array
646 * @param {!Element} elem 646 * @param {!Element} elem
647 * @param {?Array.<!WebInspector.RemoteObjectProperty>} properties 647 * @param {?Array.<!WebInspector.RemoteObjectProperty>} properties
648 */ 648 */
649 _printArray: function(array, elem, properties) 649 _printArray: function(array, elem, properties)
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
837 837
838 formatters._ = bypassFormatter; 838 formatters._ = bypassFormatter;
839 839
840 function append(a, b) 840 function append(a, b)
841 { 841 {
842 if (b instanceof Node) 842 if (b instanceof Node)
843 a.appendChild(b); 843 a.appendChild(b);
844 else if (typeof b !== "undefined") { 844 else if (typeof b !== "undefined") {
845 var toAppend = WebInspector.linkifyStringAsFragment(String(b)); 845 var toAppend = WebInspector.linkifyStringAsFragment(String(b));
846 if (currentStyle) { 846 if (currentStyle) {
847 var wrapper = createElement('span'); 847 var wrapper = createElement("span");
848 wrapper.appendChild(toAppend); 848 wrapper.appendChild(toAppend);
849 applyCurrentStyle(wrapper); 849 applyCurrentStyle(wrapper);
850 for (var i = 0; i < wrapper.children.length; ++i) 850 for (var i = 0; i < wrapper.children.length; ++i)
851 applyCurrentStyle(wrapper.children[i]); 851 applyCurrentStyle(wrapper.children[i]);
852 toAppend = wrapper; 852 toAppend = wrapper;
853 } 853 }
854 a.appendChild(toAppend); 854 a.appendChild(toAppend);
855 } 855 }
856 return a; 856 return a;
857 } 857 }
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
1337 { 1337 {
1338 if (!this._wrapperElement) { 1338 if (!this._wrapperElement) {
1339 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this ); 1339 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this );
1340 this._wrapperElement.classList.toggle("collapsed", this._collapsed); 1340 this._wrapperElement.classList.toggle("collapsed", this._collapsed);
1341 } 1341 }
1342 return this._wrapperElement; 1342 return this._wrapperElement;
1343 }, 1343 },
1344 1344
1345 __proto__: WebInspector.ConsoleViewMessage.prototype 1345 __proto__: WebInspector.ConsoleViewMessage.prototype
1346 } 1346 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698