Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove yoda disable. fix throw parens Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 813 matching lines...) Expand 10 before | Expand all | Expand 10 after
824 if (WebInspector.inspectorView.currentPanel() && WebInspector.inspec torView.currentPanel().name === "console") 824 if (WebInspector.inspectorView.currentPanel() && WebInspector.inspec torView.currentPanel().name === "console")
825 WebInspector.userMetrics.actionTaken(WebInspector.UserMetrics.Ac tion.CommandEvaluatedInConsolePanel); 825 WebInspector.userMetrics.actionTaken(WebInspector.UserMetrics.Ac tion.CommandEvaluatedInConsolePanel);
826 } 826 }
827 }, 827 },
828 828
829 /** 829 /**
830 * @param {!WebInspector.Event} event 830 * @param {!WebInspector.Event} event
831 */ 831 */
832 _commandEvaluated: function(event) 832 _commandEvaluated: function(event)
833 { 833 {
834 var data = /**{{result: ?WebInspector.RemoteObject, wasThrown: boolean, text: string, commandMessage: !WebInspector.ConsoleMessage}} */ (event.data); 834 var data = /** {{result: ?WebInspector.RemoteObject, wasThrown: boolean, text: string, commandMessage: !WebInspector.ConsoleMessage}} */ (event.data);
835 this._prompt.pushHistoryItem(data.text); 835 this._prompt.pushHistoryItem(data.text);
836 this._consoleHistorySetting.set(this._prompt.historyData().slice(-WebIns pector.ConsoleView.persistedHistorySize)); 836 this._consoleHistorySetting.set(this._prompt.historyData().slice(-WebIns pector.ConsoleView.persistedHistorySize));
837 this._printResult(data.result, data.wasThrown, data.commandMessage, data .exceptionDetails); 837 this._printResult(data.result, data.wasThrown, data.commandMessage, data .exceptionDetails);
838 }, 838 },
839 839
840 /** 840 /**
841 * @override 841 * @override
842 * @return {!Array.<!Element>} 842 * @return {!Array.<!Element>}
843 */ 843 */
844 elementsToRestoreScrollPositionsFor: function() 844 elementsToRestoreScrollPositionsFor: function()
(...skipping 486 matching lines...) Expand 10 before | Expand all | Expand 10 after
1331 return true; 1331 return true;
1332 } 1332 }
1333 return false; 1333 return false;
1334 } 1334 }
1335 } 1335 }
1336 1336
1337 /** 1337 /**
1338 * @typedef {{messageIndex: number, matchIndex: number}} 1338 * @typedef {{messageIndex: number, matchIndex: number}}
1339 */ 1339 */
1340 WebInspector.ConsoleView.RegexMatchRange; 1340 WebInspector.ConsoleView.RegexMatchRange;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698