Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 return this._selectNextVisibleCallFrame(index - 1, true); 326 return this._selectNextVisibleCallFrame(index - 1, true);
327 }, 327 },
328 328
329 /** 329 /**
330 * @param {number} index 330 * @param {number} index
331 * @param {boolean=} backward 331 * @param {boolean=} backward
332 * @return {boolean} 332 * @return {boolean}
333 */ 333 */
334 _selectNextVisibleCallFrame: function(index, backward) 334 _selectNextVisibleCallFrame: function(index, backward)
335 { 335 {
336 /* eslint-disable yoda */
pfeldman 2016/04/22 14:22:07 We can rewrite it to make lint happy - I also can'
paulirish 2016/04/22 18:28:50 being addressed by kozyatinskiy. I'll remove the a
336 while (0 <= index && index < this.callFrames.length) { 337 while (0 <= index && index < this.callFrames.length) {
338 /* eslint-enable yoda */
337 var callFrame = this.callFrames[index]; 339 var callFrame = this.callFrames[index];
338 if (!callFrame.isHidden() && !callFrame.isLabel() && !callFrame._asy ncCallFrame) { 340 if (!callFrame.isHidden() && !callFrame.isLabel() && !callFrame._asy ncCallFrame) {
339 this._callFrameSelected(callFrame); 341 this._callFrameSelected(callFrame);
340 return true; 342 return true;
341 } 343 }
342 index += backward ? -1 : 1; 344 index += backward ? -1 : 1;
343 } 345 }
344 return false; 346 return false;
345 }, 347 },
346 348
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 var uiLocation = liveLocation.uiLocation(); 469 var uiLocation = liveLocation.uiLocation();
468 if (!uiLocation) 470 if (!uiLocation)
469 return; 471 return;
470 var text = uiLocation.linkText(); 472 var text = uiLocation.linkText();
471 this.setSubtitle(text.trimMiddle(30)); 473 this.setSubtitle(text.trimMiddle(30));
472 this.subtitleElement.title = text; 474 this.subtitleElement.title = text;
473 }, 475 },
474 476
475 __proto__: WebInspector.UIList.Item.prototype 477 __proto__: WebInspector.UIList.Item.prototype
476 } 478 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698