Allows to dump current snippets to a json in the Downloads folder.

Allows to dump current snippets to a json in the Downloads folder.

The feature is accessible by a new button on the page
chrome://snippets-internals.

Also changes a few details in the JS for the internals page
(inlining callbacks, geting rid of the arrow function to pass
presubmit).

Introduces a getter in the service for snippets (the asymmetric
access via iterators to be removed in another CL).

BUG=604740
Committed: https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659
Cr-Commit-Position: refs/heads/master@{#389466}

[jkrcal, 2016-04-22 08:37:41]

Description was changed from

==========
Allows to dump current snippets to a json in the Downloads folder.

The feature is accessible by a new button on the page
chrome://snippets-internals. Also changes a few details in the JS for
the internals page (inlining callbacks, geting rid of the arrow
function to pass presubmit).

BUG=604740
==========

to

==========
Allows to dump current snippets to a json in the Downloads folder.

The feature is accessible by a new button on the page
chrome://snippets-internals. 

Also changes a few details in the JS for the internals page 
(inlining callbacks, geting rid of the arrow function to pass 
presubmit). 

Introduces a getter in the service for snippets (the asymmetric 
access via iterators to be removed in another CL).

BUG=604740
==========

[jkrcal, 2016-04-22 08:44:39]

jkrcal@chromium.org changed reviewers:
+ bauerb@chromium.org

[jkrcal, 2016-04-22 08:44:39]

Please take a look at the whole CL.

[Bernhard Bauer, 2016-04-22 08:59:44]

So, browsers already contain a mechanism for downloading files. Why don't you
just provide the snippets to the Web UI page and serve it from there as a data:
URL with Content-Disposition: attachment?

[jkrcal, 2016-04-22 09:24:22]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 09:24:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907233002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907233002/1

[commit-bot: I haz the power, 2016-04-22 09:26:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 09:26:27]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[jkrcal, 2016-04-25 09:42:17]

Thanks for the hint. PTAL now.

In the end, it seems that specifying content disposition is not possible within
data: URL (at least many stackoverflow folks agreed so).

I used a simple workaround by emulating a clock on an artificial A element with
the download attribute.

[jkrcal, 2016-04-25 09:43:33]

On 2016/04/25 09:42:17, jkrcal wrote:
> Thanks for the hint. PTAL now.
> 
> In the end, it seems that specifying content disposition is not possible
within
> data: URL (at least many stackoverflow folks agreed so).
> 
> I used a simple workaround by emulating a clock on an artificial A element
with
> the download attribute.

*emulating a _click_ on...

[Bernhard Bauer, 2016-04-25 10:32:23]

https://codereview.chromium.org/1907233002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/snippets_internals.js (right):

https://codereview.chromium.org/1907233002/diff/40001/chrome/browser/resource...
chrome/browser/resources/snippets_internals.js:53: var link =
document.createElement('a');
Add a comment here that explains what you're doing?

https://codereview.chromium.org/1907233002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/snippets_internals_message_handler.cc (right):

https://codereview.chromium.org/1907233002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/snippets_internals_message_handler.cc:122:
*ntp_snippets_service_->SnippetsToListValue(
Really, you could just get the value direct from preferences, no?

https://codereview.chromium.org/1907233002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/snippets_internals_message_handler.cc:126:
base::StringValue json_value(json);
You could inline this.

[jkrcal, 2016-04-25 12:04:15]

PTAL

https://codereview.chromium.org/1907233002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/snippets_internals.js (right):

https://codereview.chromium.org/1907233002/diff/40001/chrome/browser/resource...
chrome/browser/resources/snippets_internals.js:53: var link =
document.createElement('a');
On 2016/04/25 10:32:22, Bernhard Bauer wrote:
> Add a comment here that explains what you're doing?

Done.

https://codereview.chromium.org/1907233002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/snippets_internals_message_handler.cc (right):

https://codereview.chromium.org/1907233002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/snippets_internals_message_handler.cc:122:
*ntp_snippets_service_->SnippetsToListValue(
On 2016/04/25 10:32:22, Bernhard Bauer wrote:
> Really, you could just get the value direct from preferences, no?

Done.

https://codereview.chromium.org/1907233002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/snippets_internals_message_handler.cc:126:
base::StringValue json_value(json);
On 2016/04/25 10:32:22, Bernhard Bauer wrote:
> You could inline this.

Done.

[Bernhard Bauer, 2016-04-25 12:26:38]

lgtm

[jkrcal, 2016-04-25 12:28:59]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 12:29:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907233002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907233002/60001

[commit-bot: I haz the power, 2016-04-25 13:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 13:41:44]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2016-04-25 13:42:59]

The CQ bit was checked by jkrcal@chromium.org

[commit-bot: I haz the power, 2016-04-25 13:43:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907233002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907233002/60001

[commit-bot: I haz the power, 2016-04-25 13:47:28]

Description was changed from

==========
Allows to dump current snippets to a json in the Downloads folder.

The feature is accessible by a new button on the page
chrome://snippets-internals. 

Also changes a few details in the JS for the internals page 
(inlining callbacks, geting rid of the arrow function to pass 
presubmit). 

Introduces a getter in the service for snippets (the asymmetric 
access via iterators to be removed in another CL).

BUG=604740
==========

to

==========
Allows to dump current snippets to a json in the Downloads folder.

The feature is accessible by a new button on the page
chrome://snippets-internals. 

Also changes a few details in the JS for the internals page 
(inlining callbacks, geting rid of the arrow function to pass 
presubmit). 

Introduces a getter in the service for snippets (the asymmetric 
access via iterators to be removed in another CL).

BUG=604740
==========

[commit-bot: I haz the power, 2016-04-25 13:47:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-25 13:48:46]

Description was changed from

==========
Allows to dump current snippets to a json in the Downloads folder.

The feature is accessible by a new button on the page
chrome://snippets-internals. 

Also changes a few details in the JS for the internals page 
(inlining callbacks, geting rid of the arrow function to pass 
presubmit). 

Introduces a getter in the service for snippets (the asymmetric 
access via iterators to be removed in another CL).

BUG=604740
==========

to

==========
Allows to dump current snippets to a json in the Downloads folder.

The feature is accessible by a new button on the page
chrome://snippets-internals.

Also changes a few details in the JS for the internals page
(inlining callbacks, geting rid of the arrow function to pass
presubmit).

Introduces a getter in the service for snippets (the asymmetric
access via iterators to be removed in another CL).

BUG=604740

Committed: https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659
Cr-Commit-Position: refs/heads/master@{#389466}
==========

[commit-bot: I haz the power, 2016-04-25 13:48:46]

Patchset 4 (id:??) landed as
https://crrev.com/5ed0d72d80f4b4687889c83fc7f72dd9591cc659
Cr-Commit-Position: refs/heads/master@{#389466}