flag to make kClipToLayer_SaveFlag the default behavior

flag to make kClipToLayer_SaveFlag the default behavior

#define SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG to get the old behavior

The goal is to remove the feature of saveLayer that allows the canvas to draw outside of the top-most layer.

R=robertphillips@google.com, scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13730

[reed1, 2014-03-07 19:36:06]

This one is tricky, since we want to catch callers who *didn't* specify the
flag.

[robertphillips, 2014-03-07 19:46:01]

lgtm

[scroggo, 2014-03-07 19:52:31]

lgtm

https://codereview.chromium.org/190723004/diff/20001/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/190723004/diff/20001/include/core/SkCanvas.h#...
include/core/SkCanvas.h:331: kClipToLayer_SaveFlag       = 0x10,
Maybe add a comment here?

It seems odd to have a flag that is always set.

[reed1, 2014-03-07 20:02:41]

https://codereview.chromium.org/190723004/diff/20001/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/190723004/diff/20001/include/core/SkCanvas.h#...
include/core/SkCanvas.h:331: kClipToLayer_SaveFlag       = 0x10,
On 2014/03/07 19:52:31, scroggo wrote:
> Maybe add a comment here?
> 
> It seems odd to have a flag that is always set.

Done.

[reed1, 2014-03-07 20:03:59]

I *think* this is a non-issue for Chrome, but maybe tricky for android...

[reed1, 2014-03-07 20:05:00]

I expect the canvas-layer-state gm to fail, as I've basically killed that gm.

[scroggo, 2014-03-07 20:08:32]

On 2014/03/07 20:03:59, reed1 wrote:
> I *think* this is a non-issue for Chrome, but maybe tricky for android...

lgtm

[scroggo, 2014-03-07 20:09:10]

On 2014/03/07 20:05:00, reed1 wrote:
> I expect the canvas-layer-state gm to fail, as I've basically killed that gm.

change to ignored-tests?

[reed1, 2014-03-10 18:21:41]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-03-10 18:21:51]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/190723004/90001

[commit-bot: I haz the power, 2014-03-10 19:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-10 19:36:46]

Failed to apply patch for expectations/gm/ignored-tests.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file expectations/gm/ignored-tests.txt
  Hunk #1 FAILED at 43.
  1 out of 1 hunk FAILED -- saving rejects to file
expectations/gm/ignored-tests.txt.rej

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
9ec356a0a04515445e95818133b054af55ebc0c9..a7484cbb94e1a2a746eae0c946f5e79a92833f30
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -43,3 +43,7 @@ bezier_quad_effects
 bezier_conic_effects
 bezier_cubic_effects
 
+# reed: https://codereview.chromium.org/190723004/
+# This change removes an API that this GM was testing. If/when it lands and
sticks,
+# I will likely just delete the GM.
+canvas-layer-state

[reed1, 2014-03-10 19:48:03]

Committed patchset #6 manually as r13730 (presubmit successful).