Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1907223002: Remove unnecessary use of HeapHashMap for InspectorAnimationAgent::m_idToAnimationType. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary use of HeapHashMap for InspectorAnimationAgent::m_idToAnimationType. R= BUG= Committed: https://crrev.com/2cb791bffdeedc51d854a75f3707901a12df5dfb Cr-Commit-Position: refs/heads/master@{#389369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-22 09:47:05 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-22 18:04:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907223002/1
4 years, 8 months ago (2016-04-23 05:54:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-23 06:22:18 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 06:23:20 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2cb791bffdeedc51d854a75f3707901a12df5dfb
Cr-Commit-Position: refs/heads/master@{#389369}

Powered by Google App Engine
This is Rietveld 408576698