mash/wm: Fix detecting container windows.

mash/wm/window_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mash/wm/window_manager.h"
 
 #include <stdint.h>
 
 #include <utility>
 
@@ skipping 26 matching lines @@
     for (auto child : container->children())
       child->RemoveObserver(this);
   }
 }
 
 void WindowManager::Initialize(RootWindowController* root_controller,
                                session::mojom::Session* session) {
   DCHECK(root_controller);
   DCHECK(!root_controller_);
   root_controller_ = root_controller;
-  // The children of the root are considered containers.
-  for (auto container : root_controller_->root()->children()) {
+
+  // Observe all the containers and their child windows.

[sky, 2016/04/22 15:23:42]

Why do you need to observer the child windows?

[sky, 2016/04/22 15:25:40]

Never mind this comment, I just saw your comments in your other patch and get
why you want to observe children. I think it's error prone to have this class
observe two types of windows for different purposes. I would rather you add an
observer specifically for children.

[sadrul, 2016/04/22 16:06:05]

Done (introduced a DisconnectedAppHandler). Change both WindowManager and
DisconnectedAppHandler to become WindowTrackers too, to make it easier to stop
observing during teardown.

+  int count = static_cast<int>(mojom::Container::COUNT);
+  for (int id = 1; id < count; ++id) {

[sky, 2016/04/22 15:23:42]

1 -> ROOT + 1 ?

[sadrul, 2016/04/22 16:06:06]

Done.

+    mus::Window* container = root_controller_->GetWindowForContainer(
+        static_cast<mojom::Container>(id));
     container->AddObserver(this);
-    for (auto child : container->children())
-      child->AddObserver(this);
+    for (auto child : container->children()) {
+      if (!root_controller_->WindowIsContainer(child))
+        child->AddObserver(this);
+    }
   }
 
   // The insets are roughly what is needed by CustomFrameView. The expectation
   // is at some point we'll write our own NonClientFrameView and get the insets
   // from it.
   mus::mojom::FrameDecorationValuesPtr frame_decoration_values =
       mus::mojom::FrameDecorationValues::New();
   const gfx::Insets client_area_insets =
       NonClientFrameController::GetPreferredClientAreaInsets();
   frame_decoration_values->normal_client_area_insets =
@@ skipping 42 matching lines @@
   const bool provide_non_client_frame =
       GetWindowType(*properties) == mus::mojom::WindowType::WINDOW;
   if (provide_non_client_frame)
     (*properties)[mus::mojom::kWaitForUnderlay_Property].clear();
 
   // TODO(sky): constrain and validate properties before passing to server.
   mus::Window* window = root->connection()->NewWindow(properties);
   window->SetBounds(CalculateDefaultBounds(window));
 
   mojom::Container container = GetRequestedContainer(window);
-  root_controller_->GetWindowForContainer(container)->AddChild(window);
+  mus::Window* container_window =
+      root_controller_->GetWindowForContainer(container);
+  DCHECK(root_controller_->WindowIsContainer(container_window));
+  container_window->AddChild(window);
 
   if (provide_non_client_frame) {
     NonClientFrameController::Create(root_controller_->GetConnector(), window,
                                      root_controller_->window_manager_client());
   }
 
   root_controller_->IncrementWindowCount();
 
   return window;
 }
 
 void WindowManager::OnTreeChanging(const TreeChangeParams& params) {
   DCHECK(root_controller_);
-  if (root_controller_->WindowIsContainer(params.old_parent))
+  if (params.old_parent == params.receiver &&
+      root_controller_->WindowIsContainer(params.old_parent))
     params.target->RemoveObserver(this);
-  else if (root_controller_->WindowIsContainer(params.new_parent))
+
+  if (params.new_parent == params.receiver &&
+      root_controller_->WindowIsContainer(params.new_parent))
     params.target->AddObserver(this);
 }
 
 void WindowManager::OnWindowEmbeddedAppDisconnected(mus::Window* window) {
   window->Destroy();
 }
 
 void WindowManager::SetWindowManagerClient(mus::WindowManagerClient* client) {
   window_manager_client_ = client;
 }
@@ skipping 27 matching lines @@
 
 void WindowManager::ScreenlockStateChanged(bool locked) {
   // Hide USER_PRIVATE windows when the screen is locked.
   mus::Window* window = root_controller_->GetWindowForContainer(
       mash::wm::mojom::Container::USER_PRIVATE);
   window->SetVisible(!locked);
 }
 
 }  // namespace wm
 }  // namespace mash