content/renderer/media/webrtc_audio_capturer.cc - Issue 190713004: Only turn on the audio processing by default for MEDIA_DEVICE_AUDIO_CAPTURE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_capturer.cc

Issue 190713004: Only turn on the audio processing by default for MEDIA_DEVICE_AUDIO_CAPTURE (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: added unittest to protect the use cases. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_processor_unittest.cc ('K') | « content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc ('k') | content/renderer/media/webrtc_local_audio_track_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_capturer.cc

diff --git a/content/renderer/media/webrtc_audio_capturer.cc b/content/renderer/media/webrtc_audio_capturer.cc

index f396813387a821176df21a827af07ed2e550ab58..6cf1195a46a8a8d3f24e52e4ca3168b287f4ee40 100644

--- a/content/renderer/media/webrtc_audio_capturer.cc

+++ b/content/renderer/media/webrtc_audio_capturer.cc

@@ -304,7 +304,8 @@ void WebRtcAudioCapturer::SetCapturerSource(

16, buffer_size, effects);

scoped_refptr<MediaStreamAudioProcessor> new_audio_processor(

new talk_base::RefCountedObject<MediaStreamAudioProcessor>(

- params, constraints, effects, audio_device_));

+ params, constraints, effects, device_info_.device.type,

+ audio_device_));

{

base::AutoLock auto_lock(lock_);

audio_processor_ = new_audio_processor;