Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 190713002: Replace the recursion in PropagateMinusZeroChecks() with a loop and a worklist. (Closed)

Created:
6 years, 9 months ago by Benedikt Meurer
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Replace the recursion in PropagateMinusZeroChecks() with a loop and a worklist. Also refactor the related code in preparation for fixing the range analysis. BUG=v8:3204 LOG=y R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -158 lines) Patch
M src/hydrogen-instructions.h View 10 chunks +0 lines, -41 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M src/hydrogen-minus-zero.h View 1 chunk +10 lines, -2 lines 0 comments Download
M src/hydrogen-minus-zero.cc View 2 chunks +67 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
First step. PTAL.
6 years, 9 months ago (2014-03-07 12:22:47 UTC) #1
Sven Panne
lgtm
6 years, 9 months ago (2014-03-07 12:35:14 UTC) #2
Benedikt Meurer
6 years, 9 months ago (2014-03-10 05:52:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19737 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698