Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1907083003: Add new 'Win x64', 'Win 10 Fast Ring' bot configs to MB. (Closed)

Created:
4 years, 8 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
Reviewers:
scottmg, Will Harris
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new 'Win x64', 'Win 10 Fast Ring' bot configs to MB. R=scottmg@chromium.org, wfh@chromium.org BUG=605318 Committed: https://crrev.com/995095d51f434da8cb261a8f1a3c52a89f09f403 Cr-Commit-Position: refs/heads/master@{#388979}

Patch Set 1 #

Patch Set 2 : add Win 10 Fast Ring #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 4 chunks +10 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (5 generated)
Dirk Pranke
Please take a look? This needs to land before https://codereview.chromium.org/1904313002/ lands.
4 years, 8 months ago (2016-04-21 23:12:08 UTC) #3
scottmg
lgtm
4 years, 8 months ago (2016-04-21 23:14:59 UTC) #4
Will Harris
lgtm https://codereview.chromium.org/1907083003/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1907083003/diff/20001/tools/mb/mb_config.pyl#newcode216 tools/mb/mb_config.pyl:216: 'Win 10 Fast Ring': 'gn_release_trybot_x64', observation: this turns ...
4 years, 8 months ago (2016-04-21 23:20:39 UTC) #5
Dirk Pranke
On 2016/04/21 23:20:39, Will Harris wrote: > lgtm > > https://codereview.chromium.org/1907083003/diff/20001/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): ...
4 years, 8 months ago (2016-04-21 23:22:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907083003/20001
4 years, 8 months ago (2016-04-21 23:22:40 UTC) #8
Dirk Pranke
Landing this directly to make sure I can land it, then land the build-side changes ...
4 years, 8 months ago (2016-04-22 00:29:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 00:40:54 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:42:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/995095d51f434da8cb261a8f1a3c52a89f09f403
Cr-Commit-Position: refs/heads/master@{#388979}

Powered by Google App Engine
This is Rietveld 408576698