Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1907063002: Reland of Add code to call skia's matchFamilyStyleCharacter API, which uses the (patchset #… (Closed)

Created:
4 years, 8 months ago by Ilya Kulshin
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jam, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add code to call skia's matchFamilyStyleCharacter API, which uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ ) Reland https://codereview.chromium.org/1883483002/ and rebaseline failing tests (new results are better). Also added Win10 baselines for fast/text/emphasis which isn't failing but is marked as NeedsManualRebaseline. This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138. BUG=459056 Committed: https://crrev.com/16e5c30b6ccfcb54bf27ebbd200e6ad0e3bdf9df Cr-Commit-Position: refs/heads/master@{#389131}

Patch Set 1 : Revert the revert #

Patch Set 2 : Add new baselines for failing tests #

Patch Set 3 : Add Win10 baselines for fast/text/emphasis #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -145 lines) Patch
M content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/font-fallback-win.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/font-fallback-win-expected.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/encoding/invalid-UTF-8-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/encoding/invalid-UTF-8-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/decorations-with-text-combine-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/decorations-with-text-combine-expected.txt View 1 1 chunk +37 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/emphasis-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/emphasis-expected.txt View 1 2 6 chunks +65 lines, -65 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/inspector-protocol/layout-fonts/languages-emoji-rare-glyphs-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win7/fast/encoding/invalid-UTF-8-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win7/fast/encoding/invalid-UTF-8-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.h View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDescription.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDescription.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontTraits.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp View 4 chunks +3 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp View 2 chunks +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/win/WebFontRendering.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/win/WebFontRendering.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907063002/40001
4 years, 8 months ago (2016-04-21 23:47:42 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-21 23:47:44 UTC) #7
Ilya Kulshin
ptal - this is relanding the change that was landed earlier and was reverted because ...
4 years, 8 months ago (2016-04-21 23:49:24 UTC) #10
jochen (gone - plz use gerrit)
can you change the CL description to Reland of "..." otherwise. lgtm
4 years, 8 months ago (2016-04-22 15:28:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907063002/40001
4 years, 8 months ago (2016-04-22 15:31:53 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-22 16:19:00 UTC) #16
eae
LGTM
4 years, 8 months ago (2016-04-22 16:50:45 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:48:26 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/16e5c30b6ccfcb54bf27ebbd200e6ad0e3bdf9df
Cr-Commit-Position: refs/heads/master@{#389131}

Powered by Google App Engine
This is Rietveld 408576698