Description was changed from ========== Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, ...
4 years, 8 months ago
(2016-04-21 22:04:11 UTC)
#1
Description was changed from
==========
Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, which
uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/
)"
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
to
==========
Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, which
uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/
)"
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis-expected which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
Ilya Kulshin
Description was changed from ========== Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, ...
4 years, 8 months ago
(2016-04-21 22:04:49 UTC)
#2
Description was changed from
==========
Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, which
uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/
)"
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis-expected which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
to
==========
Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, which
uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/
)"
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
Ilya Kulshin
Description was changed from ========== Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, ...
4 years, 8 months ago
(2016-04-21 23:46:19 UTC)
#3
Description was changed from
==========
Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, which
uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/
)"
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
to
==========
Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, which
uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/
)"
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
TBR=jochen@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium...
==========
Ilya Kulshin
The CQ bit was checked by kulshin@chromium.org
4 years, 8 months ago
(2016-04-21 23:46:55 UTC)
#4
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907063002/40001
4 years, 8 months ago
(2016-04-21 23:47:42 UTC)
#5
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago
(2016-04-21 23:47:44 UTC)
#7
No L-G-T-M from a valid reviewer yet.
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
Ilya Kulshin
Description was changed from ========== Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, ...
4 years, 8 months ago
(2016-04-21 23:48:45 UTC)
#8
Description was changed from
==========
Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, which
uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/
)"
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
TBR=jochen@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium...
==========
to
==========
Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, which
uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/
)"
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
ptal - this is relanding the change that was landed earlier and was reverted because ...
4 years, 8 months ago
(2016-04-21 23:49:24 UTC)
#10
ptal - this is relanding the change that was landed earlier and was reverted
because of failing Win10 tests. This patch now includes new baselines for
failing tests.
jochen (gone - plz use gerrit)
can you change the CL description to Reland of "..." otherwise. lgtm
4 years, 8 months ago
(2016-04-22 15:28:02 UTC)
#11
can you change the CL description to Reland of "..."
otherwise. lgtm
Ilya Kulshin
Description was changed from ========== Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, ...
4 years, 8 months ago
(2016-04-22 15:30:41 UTC)
#12
Description was changed from
==========
Revert "Revert of Add code to call skia's matchFamilyStyleCharacter API, which
uses the (patchset #7 id:150001 of https://codereview.chromium.org/1883483002/
)"
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
to
==========
Reland of Add code to call skia's matchFamilyStyleCharacter API, which uses the
(patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ )
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
Ilya Kulshin
The CQ bit was checked by kulshin@chromium.org
4 years, 8 months ago
(2016-04-22 15:31:10 UTC)
#13
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907063002/40001
4 years, 8 months ago
(2016-04-22 15:31:53 UTC)
#14
Description was changed from ========== Reland of Add code to call skia's matchFamilyStyleCharacter API, which ...
4 years, 8 months ago
(2016-04-22 16:18:59 UTC)
#15
Message was sent while issue was closed.
Description was changed from
==========
Reland of Add code to call skia's matchFamilyStyleCharacter API, which uses the
(patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ )
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
to
==========
Reland of Add code to call skia's matchFamilyStyleCharacter API, which uses the
(patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ )
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago
(2016-04-22 16:19:00 UTC)
#16
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
eae
LGTM
4 years, 8 months ago
(2016-04-22 16:50:45 UTC)
#17
Message was sent while issue was closed.
LGTM
commit-bot: I haz the power
Description was changed from ========== Reland of Add code to call skia's matchFamilyStyleCharacter API, which ...
4 years, 8 months ago
(2016-04-22 19:48:25 UTC)
#18
Message was sent while issue was closed.
Description was changed from
==========
Reland of Add code to call skia's matchFamilyStyleCharacter API, which uses the
(patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ )
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
==========
to
==========
Reland of Add code to call skia's matchFamilyStyleCharacter API, which uses the
(patchset #7 id:150001 of https://codereview.chromium.org/1883483002/ )
Reland https://codereview.chromium.org/1883483002/ and rebaseline
failing tests (new results are better).
Also added Win10 baselines for fast/text/emphasis which
isn't failing but is marked as NeedsManualRebaseline.
This reverts commit 6485a0d3465ba3b0bcca6385f8740a5c2e7c0138.
BUG=459056
Committed: https://crrev.com/16e5c30b6ccfcb54bf27ebbd200e6ad0e3bdf9df
Cr-Commit-Position: refs/heads/master@{#389131}
==========
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/16e5c30b6ccfcb54bf27ebbd200e6ad0e3bdf9df Cr-Commit-Position: refs/heads/master@{#389131}
4 years, 8 months ago
(2016-04-22 19:48:26 UTC)
#19
Issue 1907063002: Reland of Add code to call skia's matchFamilyStyleCharacter API, which uses the (patchset #…
(Closed)
Created 4 years, 8 months ago by Ilya Kulshin
Modified 4 years, 8 months ago
Reviewers: jochen (gone - plz use gerrit), apacible, bungeman-chromium, drott, eae
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0