cc: Make CallFunctionForEveryLayer use LayerListIterator

cc/trees/draw_property_utils.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/draw_property_utils.h"
 
 #include <stddef.h>
 
 #include <vector>
 
@@ skipping 402 matching lines @@
                           const TransformTree& transform_tree,
                           const EffectTree& effect_tree) {
   return LayerShouldBeSkippedInternal(layer, layer_is_drawn, transform_tree,
                                       effect_tree);
 }
 
 void FindLayersThatNeedUpdates(LayerTreeHost* layer_tree_host,
                                const TransformTree& transform_tree,
                                const EffectTree& effect_tree,
                                LayerList* update_layer_list) {
-  LayerTreeHostCommon::CallFunctionForEveryLayer(
-      layer_tree_host,
-      [&](Layer* layer) {
-        bool layer_is_drawn =
-            effect_tree.Node(layer->effect_tree_index())->data.is_drawn;
+  for (auto* layer : *layer_tree_host) {
+    bool layer_is_drawn =
+        effect_tree.Node(layer->effect_tree_index())->data.is_drawn;
 
-        if (!IsRootLayer(layer) &&
-            LayerShouldBeSkipped(layer, layer_is_drawn, transform_tree,
-                                 effect_tree))
-          return;
+    if (!IsRootLayer(layer) &&
+        LayerShouldBeSkipped(layer, layer_is_drawn, transform_tree,
+                             effect_tree))

[Ian Vollick, 2016/04/23 00:50:24]

I believe that this should be a continue, not a return now that you've switch to
a for loop here.

+      return;
 
-        if (LayerNeedsUpdate(layer, layer_is_drawn, transform_tree)) {
-          update_layer_list->push_back(layer);
-        }
+    if (LayerNeedsUpdate(layer, layer_is_drawn, transform_tree)) {
+      update_layer_list->push_back(layer);
+    }
 
-        // Append mask layers to the update layer list. They don't have valid
-        // visible rects, so need to get added after the above calculation.
-        // Replica layers don't need to be updated.
-        if (Layer* mask_layer = layer->mask_layer())
-          update_layer_list->push_back(mask_layer);
-        if (Layer* replica_layer = layer->replica_layer()) {
-          if (Layer* mask_layer = replica_layer->mask_layer())
-            update_layer_list->push_back(mask_layer);
-        }
-      },
-      CallFunctionLayerType::BASIC_LAYER);
+    // Append mask layers to the update layer list. They don't have valid
+    // visible rects, so need to get added after the above calculation.
+    // Replica layers don't need to be updated.
+    if (Layer* mask_layer = layer->mask_layer())
+      update_layer_list->push_back(mask_layer);
+    if (Layer* replica_layer = layer->replica_layer()) {
+      if (Layer* mask_layer = replica_layer->mask_layer())
+        update_layer_list->push_back(mask_layer);
+    }
+  }
 }
 
 static void ResetIfHasNanCoordinate(gfx::RectF* rect) {
   if (std::isnan(rect->x()) || std::isnan(rect->y()) ||
       std::isnan(rect->right()) || std::isnan(rect->bottom()))
     *rect = gfx::RectF();
 }
 
 void ComputeClips(ClipTree* clip_tree,
                   const TransformTree& transform_tree,
@@ skipping 664 matching lines @@
 void UpdateElasticOverscroll(PropertyTrees* property_trees,
                              const Layer* overscroll_elasticity_layer,
                              const gfx::Vector2dF& elastic_overscroll) {
   UpdateElasticOverscrollInternal(property_trees, overscroll_elasticity_layer,
                                   elastic_overscroll);
 }
 
 }  // namespace draw_property_utils
 
 }  // namespace cc