cc: Make CallFunctionForEveryLayer use LayerListIterator

cc: Make CallFunctionForEveryLayer use LayerListIterator

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

CallFunctionForEveryLayer is expected to call function for all mask_layers
and replica_layers.

BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/859104151c4a26dc2c9d1e3337253ef8ddc126f3
Cr-Commit-Position: refs/heads/master@{#389487}

[sunxd, 2016-04-21 21:15:05]

Description was changed from

==========
cc: Remove CallFunctionForEveryLayer

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

BUG=603181
==========

to

==========
cc: Remove CallFunctionForEveryLayer

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-04-21 21:16:03]

Description was changed from

==========
cc: Remove CallFunctionForEveryLayer

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Remove CallFunctionForEveryLayer

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sunxd, 2016-04-21 21:16:04]

sunxd@chromium.org changed reviewers:
+ ajuma@chromium.org, jaydasika@chromium.org, vollick@chromium.org

[jaydasika, 2016-04-21 21:49:25]

On 2016/04/21 21:16:16, sunxd wrote:

Instead of checking for masks and replicas everywhere, I have an inclination
towards retaining CallFunctionForLayer (you would still delete
CallFunctionForEveryLayer and use the iterator directly). WDYT ?

[ajuma, 2016-04-21 21:50:00]

There seem to be a lot of places where we want to call a function on a layer as
well as on its mask, replica, and replica mask. What if we keep something like
CallFunctionOnLayer to do this? Then we'd use the iterator to do the iteration
over layers, and whenever we need to do the same thing to the layer, mask, and
replica mask, we'd use CallFunctionOnLayer. Wdyt?

[sunxd, 2016-04-22 14:43:58]

On 2016/04/21 21:50:00, ajuma wrote:
> There seem to be a lot of places where we want to call a function on a layer
as
> well as on its mask, replica, and replica mask. What if we keep something like
> CallFunctionOnLayer to do this? Then we'd use the iterator to do the iteration
> over layers, and whenever we need to do the same thing to the layer, mask, and
> replica mask, we'd use CallFunctionOnLayer. Wdyt?

This sounds to me that we do not need to delete CallFunctionForEveryLayer. We
can
have a CallFunctionForEveryLayer specifically used by callers who want to access
mask layers and replica layers. For other caller (draw_property_utils), it can
use
LayerListIterator instead.

[Ian Vollick, 2016-04-22 15:57:28]

On 2016/04/22 14:44:54, sunxd wrote:

lgtm % ajuma/jaydasika, though you'll need to update your CL's description, etc.

[jaydasika, 2016-04-22 16:27:19]

lgtm

[ajuma, 2016-04-22 17:23:41]

lgtm too

[sunxd, 2016-04-22 17:40:21]

The CQ bit was checked by sunxd@chromium.org

[commit-bot: I haz the power, 2016-04-22 17:40:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907053004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907053004/20001

[sunxd, 2016-04-22 18:40:03]

Description was changed from

==========
cc: Remove CallFunctionForEveryLayer

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Make CallFunctionForEveryLayer use LayerListIterator

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

CallFunctionForEveryLayer is expected to call function for all mask_layers
and replica_layers.

BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-22 19:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 19:06:35]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[Ian Vollick, 2016-04-23 00:50:24]

https://codereview.chromium.org/1907053004/diff/20001/cc/trees/draw_property_...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/1907053004/diff/20001/cc/trees/draw_property_...
cc/trees/draw_property_utils.cc:429: effect_tree))
I believe that this should be a continue, not a return now that you've switch to
a for loop here.

[sunxd, 2016-04-25 14:19:46]

The CQ bit was checked by sunxd@chromium.org

[sunxd, 2016-04-25 14:19:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
vollick@chromium.org, jaydasika@chromium.org, ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1907053004/#ps40001
(title: "FindLayers should skip layers instead of returning when switching from
call-function to iteration l…")

[commit-bot: I haz the power, 2016-04-25 14:20:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907053004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907053004/40001

[commit-bot: I haz the power, 2016-04-25 14:27:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 14:27:10]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[sunxd, 2016-04-25 14:39:25]

The CQ bit was checked by sunxd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 14:39:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907053004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907053004/40001

[commit-bot: I haz the power, 2016-04-25 14:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 14:46:44]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[sunxd, 2016-04-25 15:48:25]

The CQ bit was checked by sunxd@chromium.org

[commit-bot: I haz the power, 2016-04-25 15:48:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907053004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907053004/40001

[commit-bot: I haz the power, 2016-04-25 16:07:29]

Description was changed from

==========
cc: Make CallFunctionForEveryLayer use LayerListIterator

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

CallFunctionForEveryLayer is expected to call function for all mask_layers
and replica_layers.

BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Make CallFunctionForEveryLayer use LayerListIterator

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

CallFunctionForEveryLayer is expected to call function for all mask_layers
and replica_layers.

BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-25 16:07:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-25 16:09:23]

Description was changed from

==========
cc: Make CallFunctionForEveryLayer use LayerListIterator

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

CallFunctionForEveryLayer is expected to call function for all mask_layers
and replica_layers.

BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Make CallFunctionForEveryLayer use LayerListIterator

Now that we have a main thread and impl thread layer list iterator. We
should use the iterator to perform those methods on every layer. The old
traversal way should be abandoned.

CallFunctionForEveryLayer is expected to call function for all mask_layers
and replica_layers.

BUG=603181
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/859104151c4a26dc2c9d1e3337253ef8ddc126f3
Cr-Commit-Position: refs/heads/master@{#389487}
==========

[commit-bot: I haz the power, 2016-04-25 16:09:25]

Patchset 3 (id:??) landed as
https://crrev.com/859104151c4a26dc2c9d1e3337253ef8ddc126f3
Cr-Commit-Position: refs/heads/master@{#389487}