Add :media_feature dependency for GN media/base and media/base/test_support targets

Add :media_feature dependency for GN media/base and media/base/test_support targets

The media/media_features.h header is generated by //media:media_features
GN target. I've included that header into video_decoder_config.h. But
turns out the video_decoder_config.h header is used in targets other
than //media (which already has a dependency on //media:media_features).
We need to add //media:media_features dependency for all targets that
use video_decoder_config.h header.

BUG=605700
Committed: https://crrev.com/c1a9e6d597840d7f479cfc9563c8fc69038819de
Cr-Commit-Position: refs/heads/master@{#388907}

[servolk, 2016-04-21 20:28:10]

Description was changed from

==========
Add :media_feature dependency for GN media/base and media/base/test_support
targets

BUG=605700
==========

to

==========
Add :media_feature dependency for GN media/base and media/base/test_support
targets

BUG=605700
==========

[servolk, 2016-04-21 20:28:11]

servolk@chromium.org changed reviewers:
+ xhwang@chromium.org

[servolk, 2016-04-21 20:29:42]

Description was changed from

==========
Add :media_feature dependency for GN media/base and media/base/test_support
targets

BUG=605700
==========

to

==========
Add :media_feature dependency for GN media/base and media/base/test_support
targets

The media/media_features.h header is generated by //media:media_features
GN target. I've included that header into video_decoder_config.h. But
turns out the video_decoder_config.h header is used in targets other
than //media (which already has a dependency on //media:media_features).
We need to add //media:media_features dependency for all targets that
use video_decoder_config.h header.

BUG=605700
==========

[servolk, 2016-04-21 20:55:55]

servolk@chromium.org changed reviewers:
+ ddorwin@chromium.org

[servolk, 2016-04-21 21:03:28]

servolk@chromium.org changed reviewers:
+ wolenetz@chromium.org

[xhwang, 2016-04-21 21:20:09]

lgtm

[wolenetz, 2016-04-21 21:23:06]

lgtm

[servolk, 2016-04-21 21:25:29]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2016-04-21 21:25:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907003002/1

[wolenetz, 2016-04-21 21:26:01]

aside: Is similar necessary for GYP, too?

[servolk, 2016-04-21 21:31:52]

On 2016/04/21 21:26:01, wolenetz wrote:
> aside: Is similar necessary for GYP, too?

GYP build is structured slightly differently. There's no separate
//media/base:test_support target, like in GN.
And GYP media_test_support target (which includes the files that belong to GN
//media/base:test_support) already explicitly depends on GYP media target, which
depends on media_features.

[commit-bot: I haz the power, 2016-04-21 21:35:43]

Description was changed from

==========
Add :media_feature dependency for GN media/base and media/base/test_support
targets

The media/media_features.h header is generated by //media:media_features
GN target. I've included that header into video_decoder_config.h. But
turns out the video_decoder_config.h header is used in targets other
than //media (which already has a dependency on //media:media_features).
We need to add //media:media_features dependency for all targets that
use video_decoder_config.h header.

BUG=605700
==========

to

==========
Add :media_feature dependency for GN media/base and media/base/test_support
targets

The media/media_features.h header is generated by //media:media_features
GN target. I've included that header into video_decoder_config.h. But
turns out the video_decoder_config.h header is used in targets other
than //media (which already has a dependency on //media:media_features).
We need to add //media:media_features dependency for all targets that
use video_decoder_config.h header.

BUG=605700
==========

[commit-bot: I haz the power, 2016-04-21 21:35:44]

Committed patchset #1 (id:1)

[apacible, 2016-04-21 22:25:36]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1910273002/ by apacible@chromium.org.

The reason for reverting is: Win build compiler error:
https://build.chromium.org/p/chromium/builders/Win/builds/42636.

[servolk, 2016-04-21 22:59:11]

On 2016/04/21 22:25:36, apacible wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1910273002/ by mailto:apacible@chromium.org.
> 
> The reason for reverting is: Win build compiler error:
> https://build.chromium.org/p/chromium/builders/Win/builds/42636.

Hmm, I'm not sure how this CL could possibly affect Win build, since it changes
only .gn files and looks like it did fix the precise64 linux build (see
https://chromegw.corp.google.com/i/official.desktop.continuous/builders/preci...),
which is using GN.
Win build seems to be using GYP, so it looks like I was wrong in comment #13
above and we do need to add those new deps to gyp targets after all, here is a
new CL which contains both GN changes from this one and add GYP deps as well:
https://codereview.chromium.org/1912923002/

[commit-bot: I haz the power, 2016-04-22 19:39:49]

Description was changed from

==========
Add :media_feature dependency for GN media/base and media/base/test_support
targets

The media/media_features.h header is generated by //media:media_features
GN target. I've included that header into video_decoder_config.h. But
turns out the video_decoder_config.h header is used in targets other
than //media (which already has a dependency on //media:media_features).
We need to add //media:media_features dependency for all targets that
use video_decoder_config.h header.

BUG=605700
==========

to

==========
Add :media_feature dependency for GN media/base and media/base/test_support
targets

The media/media_features.h header is generated by //media:media_features
GN target. I've included that header into video_decoder_config.h. But
turns out the video_decoder_config.h header is used in targets other
than //media (which already has a dependency on //media:media_features).
We need to add //media:media_features dependency for all targets that
use video_decoder_config.h header.

BUG=605700

Committed: https://crrev.com/c1a9e6d597840d7f479cfc9563c8fc69038819de
Cr-Commit-Position: refs/heads/master@{#388907}
==========

[commit-bot: I haz the power, 2016-04-22 19:39:50]

Patchset 1 (id:??) landed as
https://crrev.com/c1a9e6d597840d7f479cfc9563c8fc69038819de
Cr-Commit-Position: refs/heads/master@{#388907}