Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1906923002: [modules] Infer strict mode from within scope object (Closed)

Created:
4 years, 8 months ago by mike3
Modified:
4 years, 8 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Infer strict mode from within scope object Refactor the Scope object to automatically enable strict mode when initialized as a "module" scope, relieving the caller of this responsibility. BUG=v8:4941 LOG=N R=adamk@chromium.org Committed: https://crrev.com/b86ec743955c2f930da5f85e2be78e4da33aed13 Cr-Commit-Position: refs/heads/master@{#35730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/ast/scopes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
mike3
4 years, 8 months ago (2016-04-21 19:10:14 UTC) #1
adamk
lgtm
4 years, 8 months ago (2016-04-21 20:03:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906923002/1
4 years, 8 months ago (2016-04-21 21:16:44 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/562)
4 years, 8 months ago (2016-04-21 23:20:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906923002/1
4 years, 8 months ago (2016-04-21 23:45:32 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/561)
4 years, 8 months ago (2016-04-22 01:48:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906923002/1
4 years, 8 months ago (2016-04-22 13:13:03 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 13:37:18 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:40 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b86ec743955c2f930da5f85e2be78e4da33aed13
Cr-Commit-Position: refs/heads/master@{#35730}

Powered by Google App Engine
This is Rietveld 408576698