Replace CFX_RectArray with std::vector<CFX_FloatRect>

Replace CFX_RectArray with std::vector<CFX_FloatRect>

Use RVO now that we use an array type compatible with it.

Committed: https://pdfium.googlesource.com/pdfium/+/df964dfb34e648e27dce7bef785b204894a7058a

[Tom Sepez, 2016-04-21 18:44:01]

Description was changed from

==========
Replace CFX_RectArray with std::vector<CFX_FloatRect>

Use RVO now that we use an array type compatible with it.
==========

to

==========
Replace CFX_RectArray with std::vector<CFX_FloatRect>

Use RVO now that we use an array type compatible with it.
==========

[Tom Sepez, 2016-04-21 18:44:01]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-21 18:44:10]

Lei, for review.

[Lei Zhang, 2016-04-21 18:51:29]

lgtm

https://codereview.chromium.org/1906903002/diff/1/core/fpdftext/fpdf_text_int...
File core/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/1906903002/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:2282: std::vector<CFX_FloatRect>
CPDF_TextPageFind::GetRectArray() const {
Can you double check and see if this is actually used?

[Tom Sepez, 2016-04-21 18:55:31]

https://codereview.chromium.org/1906903002/diff/1/core/fpdftext/fpdf_text_int...
File core/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/1906903002/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:2282: std::vector<CFX_FloatRect>
CPDF_TextPageFind::GetRectArray() const {
On 2016/04/21 18:51:29, Lei Zhang wrote:
> Can you double check and see if this is actually used?

Done.

[Tom Sepez, 2016-04-21 18:56:32]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-21 18:56:33]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1906903002/#ps20001
(title: "Remove unused method")

[commit-bot: I haz the power, 2016-04-21 18:56:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906903002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906903002/20001

[commit-bot: I haz the power, 2016-04-21 19:09:43]

Description was changed from

==========
Replace CFX_RectArray with std::vector<CFX_FloatRect>

Use RVO now that we use an array type compatible with it.
==========

to

==========
Replace CFX_RectArray with std::vector<CFX_FloatRect>

Use RVO now that we use an array type compatible with it.

Committed:
https://pdfium.googlesource.com/pdfium/+/df964dfb34e648e27dce7bef785b204894a7...
==========

[commit-bot: I haz the power, 2016-04-21 19:09:44]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/df964dfb34e648e27dce7bef785b204894a7...