Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 1906843002: Remove use of SkCanvas::LayerIter in getCanvasClipAsRegion (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of SkCanvas::LayerIter in getCanvasClipAsRegion The LayerIter is going away in https://codereview.chromium.org/1897863008/ (Hide SkCanvas::LayerIter) this replaces Chromium's sole use of it with a less powerful access mechanism. Committed: https://crrev.com/7eb22b9f183b9fdbeaf71d195b34c3282d172e3a Cr-Commit-Position: refs/heads/master@{#388813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 8 months ago (2016-04-21 15:13:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906843002/1
4 years, 8 months ago (2016-04-21 15:16:58 UTC) #5
f(malita)
lgtm
4 years, 8 months ago (2016-04-21 15:57:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906843002/1
4 years, 8 months ago (2016-04-21 15:57:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 17:58:53 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:36:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7eb22b9f183b9fdbeaf71d195b34c3282d172e3a
Cr-Commit-Position: refs/heads/master@{#388813}

Powered by Google App Engine
This is Rietveld 408576698