Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 1906833002: Disable page_cycler.intl_ko_th_vi.referehce on Mac 10.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index 8ee83f2c5d2f0a95774510b6c22d9517b57a8e4c..e32ab036933de4097708405799119177c0c4c842 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -119,9 +119,12 @@ class PageCyclerIntlKoThVi(_PageCycler):
return 'page_cycler.intl_ko_th_vi'
@classmethod
- def ShouldDisable(cls, possible_browser): # http://crbug.com/597656
- return (possible_browser.browser_type == 'reference' and
- possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
+ def ShouldDisable(cls, possible_browser):
+ # http://crbug.com/597656 (Android Nexus 5X).
+ # http://crbug.com/605543 (Mac Snow Leopard).
+ return (possible_browser.browser_type == 'reference' and (
+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or
+ possible_browser.platform.GetOSVersionName() == 'snowleopard'))
class PageCyclerMorejs(_PageCycler):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698