Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: src/runtime/runtime-function.cc

Issue 1906823002: Move of the type feedback vector to the closure. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime-profiler.cc ('k') | src/runtime/runtime-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/compiler.h" 9 #include "src/compiler.h"
10 #include "src/frames-inl.h" 10 #include "src/frames-inl.h"
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 181
182 // Set the code, scope info, formal parameter count, and the length 182 // Set the code, scope info, formal parameter count, and the length
183 // of the target shared function info. 183 // of the target shared function info.
184 target_shared->ReplaceCode(source_shared->code()); 184 target_shared->ReplaceCode(source_shared->code());
185 if (source_shared->HasBytecodeArray()) { 185 if (source_shared->HasBytecodeArray()) {
186 target_shared->set_bytecode_array(source_shared->bytecode_array()); 186 target_shared->set_bytecode_array(source_shared->bytecode_array());
187 } 187 }
188 target_shared->set_scope_info(source_shared->scope_info()); 188 target_shared->set_scope_info(source_shared->scope_info());
189 target_shared->set_length(source_shared->length()); 189 target_shared->set_length(source_shared->length());
190 target_shared->set_num_literals(source_shared->num_literals()); 190 target_shared->set_num_literals(source_shared->num_literals());
191 target_shared->set_feedback_vector(source_shared->feedback_vector()); 191 target_shared->set_feedback_metadata(source_shared->feedback_metadata());
192 target_shared->set_internal_formal_parameter_count( 192 target_shared->set_internal_formal_parameter_count(
193 source_shared->internal_formal_parameter_count()); 193 source_shared->internal_formal_parameter_count());
194 target_shared->set_start_position_and_type( 194 target_shared->set_start_position_and_type(
195 source_shared->start_position_and_type()); 195 source_shared->start_position_and_type());
196 target_shared->set_end_position(source_shared->end_position()); 196 target_shared->set_end_position(source_shared->end_position());
197 bool was_native = target_shared->native(); 197 bool was_native = target_shared->native();
198 target_shared->set_compiler_hints(source_shared->compiler_hints()); 198 target_shared->set_compiler_hints(source_shared->compiler_hints());
199 target_shared->set_opt_count_and_bailout_reason( 199 target_shared->set_opt_count_and_bailout_reason(
200 source_shared->opt_count_and_bailout_reason()); 200 source_shared->opt_count_and_bailout_reason());
201 target_shared->set_native(was_native); 201 target_shared->set_native(was_native);
202 target_shared->set_profiler_ticks(source_shared->profiler_ticks()); 202 target_shared->set_profiler_ticks(source_shared->profiler_ticks());
203 SharedFunctionInfo::SetScript( 203 SharedFunctionInfo::SetScript(
204 target_shared, Handle<Object>(source_shared->script(), isolate)); 204 target_shared, Handle<Object>(source_shared->script(), isolate));
205 205
206 // Set the code of the target function. 206 // Set the code of the target function.
207 target->ReplaceCode(source_shared->code()); 207 target->ReplaceCode(source_shared->code());
208 DCHECK(target->next_function_link()->IsUndefined()); 208 DCHECK(target->next_function_link()->IsUndefined());
209 209
210 // Make sure we get a fresh copy of the literal vector to avoid cross
211 // context contamination.
212 Handle<Context> context(source->context()); 210 Handle<Context> context(source->context());
213 target->set_context(*context); 211 target->set_context(*context);
214 212
215 Handle<LiteralsArray> literals = 213 // Make sure we get a fresh copy of the literal vector to avoid cross
216 LiteralsArray::New(isolate, handle(target_shared->feedback_vector()), 214 // context contamination, and that the literal vector makes it's way into
217 target_shared->num_literals(), TENURED); 215 // the target_shared optimized code map.
218 target->set_literals(*literals); 216 JSFunction::EnsureLiterals(target);
219 217
220 if (isolate->logger()->is_logging_code_events() || 218 if (isolate->logger()->is_logging_code_events() ||
221 isolate->cpu_profiler()->is_profiling()) { 219 isolate->cpu_profiler()->is_profiling()) {
222 isolate->logger()->LogExistingFunction( 220 isolate->logger()->LogExistingFunction(
223 source_shared, Handle<AbstractCode>(source_shared->abstract_code())); 221 source_shared, Handle<AbstractCode>(source_shared->abstract_code()));
224 } 222 }
225 223
226 return *target; 224 return *target;
227 } 225 }
228 226
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 DCHECK_EQ(1, args.length()); 299 DCHECK_EQ(1, args.length());
302 CONVERT_ARG_HANDLE_CHECKED(JSReceiver, function, 0); 300 CONVERT_ARG_HANDLE_CHECKED(JSReceiver, function, 0);
303 return function->IsJSBoundFunction() 301 return function->IsJSBoundFunction()
304 ? *JSBoundFunction::ToString( 302 ? *JSBoundFunction::ToString(
305 Handle<JSBoundFunction>::cast(function)) 303 Handle<JSBoundFunction>::cast(function))
306 : *JSFunction::ToString(Handle<JSFunction>::cast(function)); 304 : *JSFunction::ToString(Handle<JSFunction>::cast(function));
307 } 305 }
308 306
309 } // namespace internal 307 } // namespace internal
310 } // namespace v8 308 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime-profiler.cc ('k') | src/runtime/runtime-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698