Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1906813003: TaskScheduler: TimeDelta instead of TimeTicks in Task's constructor. (Closed)

Created:
4 years, 8 months ago by fdoray
Modified:
4 years, 8 months ago
Reviewers:
robliao, danakj, gab
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sched_2c_owned_delegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskScheduler: TimeDelta instead of TimeTicks in Task's constructor. This will avoid duplication of the logic to compute a Task's delayed run time. BUG=553459 Committed: https://crrev.com/d03e04eafd53907ce1afeb67c662e858f773862e Cr-Commit-Position: refs/heads/master@{#389680}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -37 lines) Patch
M base/task_scheduler/delayed_task_manager_unittest.cc View 1 2 4 chunks +12 lines, -12 lines 0 comments Download
M base/task_scheduler/priority_queue_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/task_scheduler/scheduler_thread_pool_impl.cc View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
A base/task_scheduler/scheduler_unique_stack.h View 1 1 chunk +91 lines, -0 lines 0 comments Download
A base/task_scheduler/scheduler_unique_stack_unittest.cc View 1 1 chunk +110 lines, -0 lines 0 comments Download
M base/task_scheduler/scheduler_worker_thread_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/sequence_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M base/task_scheduler/task.h View 1 chunk +3 lines, -4 lines 0 comments Download
M base/task_scheduler/task.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/task_scheduler/task_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
fdoray
Can you review this CL? Thanks.
4 years, 8 months ago (2016-04-21 19:34:28 UTC) #2
gab
lgtm
4 years, 8 months ago (2016-04-22 19:32:03 UTC) #3
danakj
LGTM
4 years, 8 months ago (2016-04-22 20:18:24 UTC) #5
robliao
lgtm
4 years, 8 months ago (2016-04-22 20:33:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906813003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906813003/40001
4 years, 8 months ago (2016-04-26 02:06:15 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-26 03:19:26 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 03:21:57 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d03e04eafd53907ce1afeb67c662e858f773862e
Cr-Commit-Position: refs/heads/master@{#389680}

Powered by Google App Engine
This is Rietveld 408576698