Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1906693002: Remove GetSharedMainThreadContextProvider from CompositorDependencies. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, piman+watch_chromium.org, darin-cc_chromium.org, dcheng, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GetSharedMainThreadContextProvider from CompositorDependencies. This function is not called. R=piman, sievers Committed: https://crrev.com/0b2e08e37eaa56f67f772b7c5e84bcac61b83822 Cr-Commit-Position: refs/heads/master@{#388605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M content/renderer/gpu/compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/fake_compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/fake_compositor_dependencies.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danakj
4 years, 8 months ago (2016-04-20 22:39:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906693002/1
4 years, 8 months ago (2016-04-20 22:40:16 UTC) #3
piman
lgtm
4 years, 8 months ago (2016-04-20 23:09:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906693002/1
4 years, 8 months ago (2016-04-20 23:18:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 23:59:50 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:27:48 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0b2e08e37eaa56f67f772b7c5e84bcac61b83822
Cr-Commit-Position: refs/heads/master@{#388605}

Powered by Google App Engine
This is Rietveld 408576698