Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: src/full-codegen/full-codegen.h

Issue 1906653004: [debugger] make step positions for for-of compatible with interpreter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_FULL_CODEGEN_FULL_CODEGEN_H_ 5 #ifndef V8_FULL_CODEGEN_FULL_CODEGEN_H_
6 #define V8_FULL_CODEGEN_FULL_CODEGEN_H_ 6 #define V8_FULL_CODEGEN_FULL_CODEGEN_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/assert-scope.h" 9 #include "src/assert-scope.h"
10 #include "src/ast/ast.h" 10 #include "src/ast/ast.h"
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
655 void SetReturnPosition(FunctionLiteral* fun); 655 void SetReturnPosition(FunctionLiteral* fun);
656 656
657 enum InsertBreak { INSERT_BREAK, SKIP_BREAK }; 657 enum InsertBreak { INSERT_BREAK, SKIP_BREAK };
658 658
659 // During stepping we want to be able to break at each statement, but not at 659 // During stepping we want to be able to break at each statement, but not at
660 // every (sub-)expression. That is why by default we insert breaks at every 660 // every (sub-)expression. That is why by default we insert breaks at every
661 // statement position, but not at every expression position, unless stated 661 // statement position, but not at every expression position, unless stated
662 // otherwise. 662 // otherwise.
663 void SetStatementPosition(Statement* stmt, 663 void SetStatementPosition(Statement* stmt,
664 InsertBreak insert_break = INSERT_BREAK); 664 InsertBreak insert_break = INSERT_BREAK);
665 void SetExpressionPosition(Expression* expr, 665 void SetExpressionPosition(Expression* expr);
666 InsertBreak insert_break = SKIP_BREAK);
667 666
668 // Consider an expression a statement. As such, we also insert a break. 667 // Consider an expression a statement. As such, we also insert a break.
669 // This is used in loop headers where we want to break for each iteration. 668 // This is used in loop headers where we want to break for each iteration.
670 void SetExpressionAsStatementPosition(Expression* expr); 669 void SetExpressionAsStatementPosition(Expression* expr);
671 670
672 void SetCallPosition(Expression* expr, 671 void SetCallPosition(Expression* expr,
673 TailCallMode tail_call_mode = TailCallMode::kDisallow); 672 TailCallMode tail_call_mode = TailCallMode::kDisallow);
674 673
675 void SetConstructCallPosition(Expression* expr) { 674 void SetConstructCallPosition(Expression* expr) {
676 // Currently call and construct calls are treated the same wrt debugging. 675 // Currently call and construct calls are treated the same wrt debugging.
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
1050 Address start_; 1049 Address start_;
1051 Address instruction_start_; 1050 Address instruction_start_;
1052 uint32_t length_; 1051 uint32_t length_;
1053 }; 1052 };
1054 1053
1055 1054
1056 } // namespace internal 1055 } // namespace internal
1057 } // namespace v8 1056 } // namespace v8
1058 1057
1059 #endif // V8_FULL_CODEGEN_FULL_CODEGEN_H_ 1058 #endif // V8_FULL_CODEGEN_FULL_CODEGEN_H_
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698