Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1906653004: [debugger] make step positions for for-of compatible with interpreter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1668 matching lines...) Expand 10 before | Expand all | Expand 10 after
1679 } else { 1679 } else {
1680 context()->Plug(r0); 1680 context()->Plug(r0);
1681 } 1681 }
1682 } 1682 }
1683 1683
1684 1684
1685 void FullCodeGenerator::VisitAssignment(Assignment* expr) { 1685 void FullCodeGenerator::VisitAssignment(Assignment* expr) {
1686 DCHECK(expr->target()->IsValidReferenceExpressionOrThis()); 1686 DCHECK(expr->target()->IsValidReferenceExpressionOrThis());
1687 1687
1688 Comment cmnt(masm_, "[ Assignment"); 1688 Comment cmnt(masm_, "[ Assignment");
1689 SetExpressionPosition(expr, INSERT_BREAK);
1690 1689
1691 Property* property = expr->target()->AsProperty(); 1690 Property* property = expr->target()->AsProperty();
1692 LhsKind assign_type = Property::GetAssignType(property); 1691 LhsKind assign_type = Property::GetAssignType(property);
1693 1692
1694 // Evaluate LHS expression. 1693 // Evaluate LHS expression.
1695 switch (assign_type) { 1694 switch (assign_type) {
1696 case VARIABLE: 1695 case VARIABLE:
1697 // Nothing to do here. 1696 // Nothing to do here.
1698 break; 1697 break;
1699 case NAMED_PROPERTY: 1698 case NAMED_PROPERTY:
(...skipping 2331 matching lines...) Expand 10 before | Expand all | Expand 10 after
4031 DCHECK(interrupt_address == 4030 DCHECK(interrupt_address ==
4032 isolate->builtins()->OnStackReplacement()->entry()); 4031 isolate->builtins()->OnStackReplacement()->entry());
4033 return ON_STACK_REPLACEMENT; 4032 return ON_STACK_REPLACEMENT;
4034 } 4033 }
4035 4034
4036 4035
4037 } // namespace internal 4036 } // namespace internal
4038 } // namespace v8 4037 } // namespace v8
4039 4038
4040 #endif // V8_TARGET_ARCH_ARM 4039 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698