Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1906643002:
🐨 Delete unused build/android/pylib/base/base_setup.py (Closed)
|
Created:
4 years, 8 months ago by agrieve Modified:
4 years, 8 months ago Reviewers:
jbudorick CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDelete unused build/android/pylib/base/base_setup.py
BUG=none
Committed: https://crrev.com/346c1908ef792fd99cb878397651f6dc5accbffa
Cr-Commit-Position: refs/heads/master@{#388783}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Delete unused build/android/pylib/base/base_setup.py BUG=none ========== to ========== Delete unused build/android/pylib/base/base_setup.py BUG=none ==========
agrieve@chromium.org changed reviewers: + jbudorick@chromium.org
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906643002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
On 2016/04/20 20:33:37, commit-bot: I haz the power wrote: > Dry run: Try jobs failed on following builders: > linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) failure looks like a flake. ptal
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906643002/1
huh, must've missed this one a few weeks back when I deleted a couple of big chunks of code from pylib. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906643002/1
Message was sent while issue was closed.
Description was changed from ========== Delete unused build/android/pylib/base/base_setup.py BUG=none ========== to ========== Delete unused build/android/pylib/base/base_setup.py BUG=none ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Delete unused build/android/pylib/base/base_setup.py BUG=none ========== to ========== Delete unused build/android/pylib/base/base_setup.py BUG=none Committed: https://crrev.com/346c1908ef792fd99cb878397651f6dc5accbffa Cr-Commit-Position: refs/heads/master@{#388783} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/346c1908ef792fd99cb878397651f6dc5accbffa Cr-Commit-Position: refs/heads/master@{#388783} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
