Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1906633002: Version 5.0.71.34 (cherry-pick) (Closed)

Created:
4 years, 8 months ago by adamk
Modified:
4 years, 8 months ago
Reviewers:
Dan Ehrenberg
CC:
Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0
Target Ref:
refs/pending/branch-heads/5.0
Project:
v8
Visibility:
Public.

Description

Version 5.0.71.34 (cherry-pick) Merged 9acbca18456c6d4b704f0e98004d2c78795602fe [es6] Fix bug in pattern re-writing BUG=v8:4891 LOG=N R=littledan@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/c36773fdb0fc17b0e1b3fdcf6aa76289ac230967

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +5 lines, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
adamk
4 years, 8 months ago (2016-04-20 19:15:31 UTC) #1
Dan Ehrenberg
lgtm
4 years, 8 months ago (2016-04-20 19:20:03 UTC) #2
adamk
4 years, 8 months ago (2016-04-20 19:27:08 UTC) #3
Not sure what happaned to git cl, but the landed in
http://crrev.com/c36773fdb0fc17b0e1b3fdcf6aa76289ac230967

Powered by Google App Engine
This is Rietveld 408576698