Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 190663013: Drop UseCounters for certain properties on CSSStyleDeclaration (Closed)

Created:
6 years, 9 months ago by davve
Modified:
6 years, 9 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Drop UseCounters for certain properties on CSSStyleDeclaration Blink/WebKit/IE supports properties on CSSStyleDeclaration that are the literal names of the CSS properties, for instance style['font-face']. We have two related counters for measuring how often this capability is used. The consensus on bug 290055 is that we can't drop the corresponding functionality because of high usage both on the counters and in libraries. Instead drop the counters since they have played their part. R=ojan BUG=290055 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp View 7 chunks +5 lines, -24 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
davve
What do you think, Ojan? Is it time to drop these?
6 years, 9 months ago (2014-03-10 15:38:31 UTC) #1
ojan
lgtm
6 years, 9 months ago (2014-03-11 01:55:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/190663013/1
6 years, 9 months ago (2014-03-11 01:55:31 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 02:09:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit
6 years, 9 months ago (2014-03-11 02:09:52 UTC) #5
davve
Jochen, I'm missing review from a Source/bindings owner. Care to take a look?
6 years, 9 months ago (2014-03-11 07:24:47 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-11 14:27:50 UTC) #7
davve
The CQ bit was checked by davve@opera.com
6 years, 9 months ago (2014-03-11 15:49:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/190663013/1
6 years, 9 months ago (2014-03-11 15:49:53 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 15:56:32 UTC) #10
Message was sent while issue was closed.
Change committed as 168930

Powered by Google App Engine
This is Rietveld 408576698