Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1906623003: Convert //components/mus from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //components/mus from scoped_ptr to std::unique_ptr BUG=554298 R=erg@chromium.org Committed: https://crrev.com/c314381373dc794d3875428994ec7a74edda77e4 Cr-Commit-Position: refs/heads/master@{#388625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -393 lines) Patch
M components/mus/common/event_param_traits.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M components/mus/demo/mus_demo.h View 3 chunks +6 lines, -5 lines 0 comments Download
M components/mus/demo/mus_demo.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.h View 2 chunks +6 lines, -5 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/mus/gles2/command_buffer_local.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_task_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/gpu_memory_buffer_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/mus/gles2/gpu_state.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/mus/gles2/mojo_buffer_backing.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_buffer_backing.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer.h View 3 chunks +7 lines, -6 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/mus/gles2/ozone_gpu_memory_buffer.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/mus/gles2/ozone_gpu_memory_buffer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/mus/gles2/raster_thread_helper.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/mus/mus_app.h View 3 chunks +6 lines, -6 lines 0 comments Download
M components/mus/mus_app.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M components/mus/public/cpp/context_provider.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/mus/public/cpp/input_event_handler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/in_flight_change.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M components/mus/public/cpp/lib/window_surface.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M components/mus/public/cpp/output_surface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_shelltest_base.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_server_shelltest_base.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.h View 2 chunks +6 lines, -4 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M components/mus/public/cpp/tests/window_unittest.cc View 6 chunks +16 lines, -16 lines 0 comments Download
M components/mus/public/cpp/window.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/window_manager_delegate.h View 2 chunks +5 lines, -4 lines 0 comments Download
M components/mus/public/cpp/window_surface.h View 3 chunks +6 lines, -5 lines 0 comments Download
M components/mus/public/cpp/window_tree_host_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/accelerator.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/display.h View 4 chunks +7 lines, -7 lines 0 comments Download
M components/mus/ws/display.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/display_binding.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/display_binding.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/mus/ws/display_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/display_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/mus/ws/display_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/event_dispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/event_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/event_dispatcher_unittest.cc View 50 chunks +76 lines, -73 lines 0 comments Download
M components/mus/ws/focus_controller.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/mus/ws/focus_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/platform_display.h View 5 chunks +7 lines, -7 lines 0 comments Download
M components/mus/ws/platform_display.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M components/mus/ws/server_window.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_window_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/server_window_drawn_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_window_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/server_window_surface_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_window_surface_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/test_utils.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M components/mus/ws/transient_windows_unittest.cc View 6 chunks +16 lines, -16 lines 0 comments Download
M components/mus/ws/user_display_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_manager_client_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M components/mus/ws/window_manager_factory_registry.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/window_manager_factory_registry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/window_manager_state.h View 5 chunks +8 lines, -7 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M components/mus/ws/window_manager_state_unittest.cc View 13 chunks +16 lines, -14 lines 0 comments Download
M components/mus/ws/window_server.h View 4 chunks +7 lines, -6 lines 0 comments Download
M components/mus/ws/window_server.cc View 5 chunks +16 lines, -13 lines 0 comments Download
M components/mus/ws/window_server_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/window_server_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree.h View 5 chunks +10 lines, -8 lines 0 comments Download
M components/mus/ws/window_tree.cc View 10 chunks +14 lines, -11 lines 0 comments Download
M components/mus/ws/window_tree_binding.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_client_unittest.cc View 9 chunks +16 lines, -16 lines 0 comments Download
M components/mus/ws/window_tree_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/mus/ws/window_tree_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 5 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
This is largely a search and replace. There's probably some IWYU errors (files that don't ...
4 years, 8 months ago (2016-04-20 21:57:18 UTC) #1
Elliot Glaysher
lgtm
4 years, 8 months ago (2016-04-20 22:02:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906623003/1
4 years, 8 months ago (2016-04-20 22:04:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 00:22:28 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c314381373dc794d3875428994ec7a74edda77e4
Cr-Commit-Position: refs/heads/master@{#388625}

Powered by Google App Engine
This is Rietveld 408576698