src/gpu/vk/GrVkStencilAttachment.cpp - Issue 1906623002: Update min Vulkan version to 1.0.8.0, and fix various bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkStencilAttachment.cpp

Issue 1906623002: Update min Vulkan version to 1.0.8.0, and fix various bugs (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/vk/GrVkStencilAttachment.cpp

diff --git a/src/gpu/vk/GrVkStencilAttachment.cpp b/src/gpu/vk/GrVkStencilAttachment.cpp

index 97597fc5118e7e239b19c876a67b76cd2c7770b0..a3d3af345a5a75f93260ca8be520ba5d4c5bdc52 100644

--- a/src/gpu/vk/GrVkStencilAttachment.cpp

+++ b/src/gpu/vk/GrVkStencilAttachment.cpp

@@ -42,7 +42,8 @@ GrVkStencilAttachment* GrVkStencilAttachment::Create(GrVkGpu* gpu,

imageDesc.fLevels = 1;

imageDesc.fSamples = sampleCnt;

imageDesc.fImageTiling = VK_IMAGE_TILING_OPTIMAL;

- imageDesc.fUsageFlags = VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT;

+ imageDesc.fUsageFlags = VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |

+ VK_IMAGE_USAGE_TRANSFER_DST_BIT;

imageDesc.fMemProps = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT;

const GrVkImage::Resource* imageResource = GrVkImage::CreateResource(gpu, imageDesc);