XSSAuditor doesn't handle full set of html5 entities for punctuation.

XSSAuditor doesn't handle full set of html5 entities for punctuation.

Committed: https://crrev.com/04e44060dccee711842d08652bf1c622a0f43179
Cr-Commit-Position: refs/heads/master@{#389836}

[Tom Sepez, 2016-04-20 22:54:12]

tsepez@chromium.org changed reviewers:
+ mkwst@chromium.org

[Tom Sepez, 2016-04-20 22:55:12]

Mike, for review.  There's been some public discussion about this.  I'm not sure
what this does to the false positive rate; however the alternatives all involve
understanding the "new" html5 entities for / ? # etc.

[Tom Sepez, 2016-04-21 00:09:48]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 00:11:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906603003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906603003/1

[commit-bot: I haz the power, 2016-04-21 01:59:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 01:59:14]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mike West, 2016-04-26 08:10:39]

LGTM.

https://codereview.chromium.org/1906603003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp (right):

https://codereview.chromium.org/1906603003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp:209: if (currentChar
== '&'
Hrm. This might end up being a little overagressive. *shrug* Let's land it and
find out.

https://codereview.chromium.org/1906603003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp:797: 
Nit: Newline?

[Tom Sepez, 2016-04-26 16:00:10]

https://codereview.chromium.org/1906603003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp (right):

https://codereview.chromium.org/1906603003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp:797: 
On 2016/04/26 08:10:38, Mike West (slow until 25th) wrote:
> Nit: Newline?

Done.

[Tom Sepez, 2016-04-26 16:00:13]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-26 16:00:14]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1906603003/#ps20001
(title: "Stray blank line.")

[commit-bot: I haz the power, 2016-04-26 16:00:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906603003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906603003/20001

[commit-bot: I haz the power, 2016-04-26 17:29:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 17:29:20]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Tom Sepez, 2016-04-26 18:22:28]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:22:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906603003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906603003/20001

[commit-bot: I haz the power, 2016-04-26 19:08:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-26 19:11:04]

Description was changed from

==========
XSSAuditor doesn't handle full set of html5 entities for punctuation.
==========

to

==========
XSSAuditor doesn't handle full set of html5 entities for punctuation.

Committed: https://crrev.com/04e44060dccee711842d08652bf1c622a0f43179
Cr-Commit-Position: refs/heads/master@{#389836}
==========

[commit-bot: I haz the power, 2016-04-26 19:11:06]

Patchset 2 (id:??) landed as
https://crrev.com/04e44060dccee711842d08652bf1c622a0f43179
Cr-Commit-Position: refs/heads/master@{#389836}