cc: Add UMA histogram for the number of render surfaces

cc: Add UMA histogram for the number of render surfaces

This adds browser and renderer histograms for the number of render
surfaces in the render surface layer list.

This also splits the existing histogram for the number of layers into
separate browser and renderer versions, making it more useful for
evaluating SPv2 layerization (which will only affect the renderer).

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c8a0830f08cfd0f5e6dd652e2370ae7fbdaecf5a
Cr-Commit-Position: refs/heads/master@{#388522}

[ajuma, 2016-04-20 14:50:18]

Description was changed from

==========
cc: Add UMA histogram for the number of render surfaces

This adds browser and renderer histograms for the number of render
surfaces in the RSLL.

This also splits the existing histogram for the number of layers into
separate browser and renderer versions, making it more useful for
evaluating SPv2 layerization (which will only affect the renderer).
==========

to

==========
cc: Add UMA histogram for the number of render surfaces

This adds browser and renderer histograms for the number of render
surfaces in the RSLL.

This also splits the existing histogram for the number of layers into
separate browser and renderer versions, making it more useful for
evaluating SPv2 layerization (which will only affect the renderer).
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ajuma, 2016-04-20 14:51:22]

Description was changed from

==========
cc: Add UMA histogram for the number of render surfaces

This adds browser and renderer histograms for the number of render
surfaces in the RSLL.

This also splits the existing histogram for the number of layers into
separate browser and renderer versions, making it more useful for
evaluating SPv2 layerization (which will only affect the renderer).
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Add UMA histogram for the number of render surfaces

This adds browser and renderer histograms for the number of render
surfaces in the render surface layer list.

This also splits the existing histogram for the number of layers into
separate browser and renderer versions, making it more useful for
evaluating SPv2 layerization (which will only affect the renderer).

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ajuma, 2016-04-20 14:51:22]

ajuma@chromium.org changed reviewers:
+ weiliangc@chromium.org

[weiliangc, 2016-04-20 14:57:25]

LGTM

[ajuma, 2016-04-20 15:04:33]

ajuma@chromium.org changed reviewers:
+ asvitkine@chromium.org

[ajuma, 2016-04-20 15:05:25]

+asvitkine for histograms.xml

[Alexei Svitkine (slow), 2016-04-20 15:40:31]

lgtm

https://codereview.chromium.org/1906523002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1906523002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:1069: UMA_HISTOGRAM_CUSTOM_COUNTS(
Please add the same comment above this block as there is on line 1062.

https://codereview.chromium.org/1906523002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1906523002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:5431: +<histogram
name="Compositing.Browser.NumActiveLayers">
Nit: add units= to all of these.

[ajuma, 2016-04-20 15:52:10]

https://codereview.chromium.org/1906523002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1906523002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:1069: UMA_HISTOGRAM_CUSTOM_COUNTS(
On 2016/04/20 15:40:30, Alexei Svitkine wrote:
> Please add the same comment above this block as there is on line 1062.

Done.

https://codereview.chromium.org/1906523002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1906523002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:5431: +<histogram
name="Compositing.Browser.NumActiveLayers">
On 2016/04/20 15:40:30, Alexei Svitkine wrote:
> Nit: add units= to all of these.

Done.

[ajuma, 2016-04-20 15:52:16]

The CQ bit was checked by ajuma@chromium.org

[ajuma, 2016-04-20 15:52:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
weiliangc@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1906523002/#ps20001
(title: "Address review comments")

[commit-bot: I haz the power, 2016-04-20 15:52:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906523002/20001

[commit-bot: I haz the power, 2016-04-20 17:04:07]

Description was changed from

==========
cc: Add UMA histogram for the number of render surfaces

This adds browser and renderer histograms for the number of render
surfaces in the render surface layer list.

This also splits the existing histogram for the number of layers into
separate browser and renderer versions, making it more useful for
evaluating SPv2 layerization (which will only affect the renderer).

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Add UMA histogram for the number of render surfaces

This adds browser and renderer histograms for the number of render
surfaces in the render surface layer list.

This also splits the existing histogram for the number of layers into
separate browser and renderer versions, making it more useful for
evaluating SPv2 layerization (which will only affect the renderer).

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-20 17:04:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:24:25]

Description was changed from

==========
cc: Add UMA histogram for the number of render surfaces

This adds browser and renderer histograms for the number of render
surfaces in the render surface layer list.

This also splits the existing histogram for the number of layers into
separate browser and renderer versions, making it more useful for
evaluating SPv2 layerization (which will only affect the renderer).

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Add UMA histogram for the number of render surfaces

This adds browser and renderer histograms for the number of render
surfaces in the render surface layer list.

This also splits the existing histogram for the number of layers into
separate browser and renderer versions, making it more useful for
evaluating SPv2 layerization (which will only affect the renderer).

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c8a0830f08cfd0f5e6dd652e2370ae7fbdaecf5a
Cr-Commit-Position: refs/heads/master@{#388522}
==========

[commit-bot: I haz the power, 2016-04-22 19:24:26]

Patchset 2 (id:??) landed as
https://crrev.com/c8a0830f08cfd0f5e6dd652e2370ae7fbdaecf5a
Cr-Commit-Position: refs/heads/master@{#388522}