Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 1906503002: headless: Implement convenience overloads for DevTools commands (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
Reviewers:
altimin
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Implement convenience overloads for DevTools commands Implement conveniene overloads for DevTools commands which only take required parameters. For example, instead of this: client->GetPage()->Navigate( page::NavigateParams::Builder() .SetUrl("https://www.example.com")) .Build()); you can now do this: client->GetPage()->Navigate("https://www.example.com"); BUG=595353 Committed: https://crrev.com/4e4448eebbfdd3ba279f87705129be31ffb54c55 Cr-Commit-Position: refs/heads/master@{#388527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M headless/lib/browser/domain_cc.template View 1 chunk +30 lines, -1 line 0 comments Download
M headless/lib/browser/domain_h.template View 1 chunk +1 line, -1 line 0 comments Download
M headless/lib/headless_devtools_client_browsertest.cc View 1 chunk +16 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Sami
4 years, 8 months ago (2016-04-20 12:44:06 UTC) #3
altimin
lgtm
4 years, 8 months ago (2016-04-20 16:36:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906503002/1
4 years, 8 months ago (2016-04-20 16:39:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/124886) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-20 16:43:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906503002/1
4 years, 8 months ago (2016-04-20 16:50:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 17:40:25 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e4448eebbfdd3ba279f87705129be31ffb54c55
Cr-Commit-Position: refs/heads/master@{#388527}

Powered by Google App Engine
This is Rietveld 408576698